From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] iotests: Quote $cmd in _send_qemu_cmd
Date: Tue, 15 Dec 2020 16:58:29 +0100 [thread overview]
Message-ID: <d58a3d43-5f56-d461-143f-c290f2383e83@redhat.com> (raw)
In-Reply-To: <20201215154933.GG8185@merkur.fritz.box>
On 15.12.20 16:49, Kevin Wolf wrote:
[...]
> Ah, looks like you don't even need to quote it like cmd="$1"? Maybe I
> should learn bash sometime...
No, normally you don’t, which is the reason why the "cmd=${$@: x:y}"
line wasn’t quoted so far. (Probably a bug in bash that was then fixed
in 5.1.)
> But yes, this is what I was thinking of.
OK, I’ll cook up a v2 then.
Max
prev parent reply other threads:[~2020-12-15 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 17:58 [PATCH] iotests: Quote $cmd in _send_qemu_cmd Max Reitz
2020-12-15 11:43 ` Kevin Wolf
2020-12-15 12:14 ` Max Reitz
2020-12-15 15:49 ` Kevin Wolf
2020-12-15 15:58 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58a3d43-5f56-d461-143f-c290f2383e83@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).