From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghc0C-00006k-Ry for qemu-devel@nongnu.org; Thu, 10 Jan 2019 10:12:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghc0B-0004C9-JP for qemu-devel@nongnu.org; Thu, 10 Jan 2019 10:12:12 -0500 From: Vladimir Sementsov-Ogievskiy Date: Thu, 10 Jan 2019 15:12:01 +0000 Message-ID: References: <20190110071330.28136-1-eblake@redhat.com> <20190110071330.28136-3-eblake@redhat.com> <7bead05e-672a-fdc2-6291-e72090defb66@virtuozzo.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "jsnow@redhat.com" , "qemu-block@nongnu.org" , Kevin Wolf , Max Reitz MTAuMDEuMjAxOSAxNzo0NCwgRXJpYyBCbGFrZSB3cm90ZToNCj4gT24gMS8xMC8xOSA0OjQwIEFN LCBWbGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IHdyb3RlOg0KPj4gMTAuMDEuMjAxOSAxMDox MywgRXJpYyBCbGFrZSB3cm90ZToNCj4+PiBUaGUgZXhpc3RpbmcgTkJEIGNvZGUgaGFkIGEgd2Vp cmQgc3BsaXQgd2hlcmUgbmJkX2V4cG9ydF9uZXcoKQ0KPj4+IGNyZWF0ZWQgYW4gZXhwb3J0IGJ1 dCBkaWQgbm90IGFkZCBpdCB0byB0aGUgbGlzdCBvZiBleHBvcnRlZA0KPj4+IG5hbWVzIHVudGls IGEgbGF0ZXIgbmJkX2V4cG9ydF9zZXRfbmFtZSgpIGNhbWUgYWxvbmcgYW5kIGdyYWJiZWQNCj4+ PiBhIHNlY29uZCByZWZlcmVuY2Ugb24gdGhlIG9iamVjdDsgbGF0ZXIsIG5iZF9leHBvcnRfY2xv c2UoKQ0KPj4+IGRyb3BzIHRoZSBzZWNvbmQgcmVmZXJlbmNlLiAgQnV0IHNpbmNlIHdlIG5ldmVy IGNoYW5nZSB0aGUNCj4+PiBuYW1lIG9mIGFuIE5CRCBleHBvcnQgd2hpbGUgaXQgaXMgZXhwb3Nl ZCwgaXQgaXMgZWFzaWVyIHRvIGp1c3QNCj4+PiBpbmxpbmUgdGhlIHByb2Nlc3Mgb2Ygc2V0dGlu ZyB0aGUgbmFtZSBhcyBwYXJ0IG9mIGNyZWF0aW5nIHRoZQ0KPj4+IGV4cG9ydC4NCj4+Pg0KPj4+ IElubGluZSB0aGUgY29udGVudHMgb2YgbmJkX2V4cG9ydF9zZXRfbmFtZSgpIGFuZA0KPj4+IG5i ZF9leHBvcnRfc2V0X2Rlc2NyaXB0aW9uKCkgaW50byB0aGUgdHdvIHBvaW50cyBpbiBhbiBleHBv cnQNCj4+PiBsaWZlY3ljbGUgd2hlcmUgdGhleSBtYXR0ZXIsIHRoZW4gYWRqdXN0IGJvdGggY2Fs bGVycyB0byBwYXNzDQo+Pj4gdGhlIG5hbWUgdXAgZnJvbnQuICBOb3RlIHRoYXQgYWxsIGNhbGxl cnMgcGFzcyBhIG5vbi1OVUxMIG5hbWUsDQo+Pj4gKHBhc3NpbmcgTlVMTCBhdCBjcmVhdGlvbiB3 YXMgZm9yIG9sZCBzdHlsZSBzZXJ2ZXJzLCBidXQgd2UNCj4+PiByZW1vdmVkIHN1cHBvcnQgZm9y IHRoYXQgaW4gY29tbWl0IDdmN2RmZTJhKS4NCj4gDQo+IEkgbmVlZCB0byBmaXggdGhhdCBzZW50 ZW5jZToNCj4gDQo+IA0KPj4+IC12b2lkIG5iZF9leHBvcnRfc2V0X25hbWUoTkJERXhwb3J0ICpl eHAsIGNvbnN0IGNoYXIgKm5hbWUpDQo+Pj4gLXsNCj4+PiAtICAgIGlmIChleHAtPm5hbWUgPT0g bmFtZSkgew0KPj4+IC0gICAgICAgIHJldHVybjsNCj4+PiAtICAgIH0NCj4+PiAtDQo+Pj4gLSAg ICBuYmRfZXhwb3J0X2dldChleHApOw0KPj4+IC0gICAgaWYgKGV4cC0+bmFtZSAhPSBOVUxMKSB7 DQo+Pj4gLSAgICAgICAgZ19mcmVlKGV4cC0+bmFtZSk7DQo+Pj4gLSAgICAgICAgZXhwLT5uYW1l ID0gTlVMTDsNCj4+PiAtICAgICAgICBRVEFJTFFfUkVNT1ZFKCZleHBvcnRzLCBleHAsIG5leHQp Ow0KPj4+IC0gICAgICAgIG5iZF9leHBvcnRfcHV0KGV4cCk7DQo+Pj4gLSAgICB9DQo+IA0KPiBJ biB0aGUgb2xkIGNvZGUsIGV4cC0+bmFtZSA9PSBOVUxMIHdhcyBwb3NzaWJsZSBkdXJpbmcgYSBz ZWNvbmQNCj4gbmJkX2V4cG9ydF9jbG9zZSgpLCBzbyB0aGlzIGNvbmRpdGlvbmFsIG5lZWRzIHRv IGJlIHByZXNlcnZlZCBpZg0KPiBuYmRfZXhwb3J0X2Nsb3NlKCkgY2FuIGJlIGNhbGxlZCBtb3Jl IHRoYW4gb25jZSBvbiB0aGUgc2FtZSBleHAuDQo+IA0KPj4+IC0gICAgaWYgKG5hbWUgIT0gTlVM TCkgew0KPj4+IC0gICAgICAgIG5iZF9leHBvcnRfZ2V0KGV4cCk7DQo+Pj4gLSAgICAgICAgZXhw LT5uYW1lID0gZ19zdHJkdXAobmFtZSk7DQo+Pj4gLSAgICAgICAgUVRBSUxRX0lOU0VSVF9UQUlM KCZleHBvcnRzLCBleHAsIG5leHQpOw0KPj4+IC0gICAgfQ0KPiANCj4gV2hlcmVhcyB0aGlzIGNv bmRpdGlvbmFsIHdhcyBvbmx5IHBvc3NpYmxlIHJpZ2h0IGFmdGVyIG5iZF9leHBvcnRfbmV3KCks DQo+IGFuZCB3YXMgYWx3YXlzIG5vbi1OVUxMLCBoZW5jZSBJIGNvbnZlcnRlZCBpdCB0byBhbiBh c3NlcnQoKSBmb3IgYQ0KPiBub24tTlVMTCBuYW1lIGFuZCB1bmNvbmRpdGlvbmFsIGNvZGUuDQo+ IA0KPj4+IC0gICAgbmJkX2V4cG9ydF9wdXQoZXhwKTsNCj4+PiAtfQ0KPj4+IC0NCj4+PiAtdm9p ZCBuYmRfZXhwb3J0X3NldF9kZXNjcmlwdGlvbihOQkRFeHBvcnQgKmV4cCwgY29uc3QgY2hhciAq ZGVzY3JpcHRpb24pDQo+Pj4gLXsNCj4+PiAtICAgIGdfZnJlZShleHAtPmRlc2NyaXB0aW9uKTsN Cj4+PiAtICAgIGV4cC0+ZGVzY3JpcHRpb24gPSBnX3N0cmR1cChkZXNjcmlwdGlvbik7DQo+Pj4g LX0NCj4+PiAtDQo+Pj4gICAgdm9pZCBuYmRfZXhwb3J0X2Nsb3NlKE5CREV4cG9ydCAqZXhwKQ0K Pj4+ICAgIHsNCj4+PiAgICAgICAgTkJEQ2xpZW50ICpjbGllbnQsICpuZXh0Ow0KPj4+IEBAIC0x NTY4LDggKzE1NDksMTQgQEAgdm9pZCBuYmRfZXhwb3J0X2Nsb3NlKE5CREV4cG9ydCAqZXhwKQ0K Pj4+ICAgICAgICBRVEFJTFFfRk9SRUFDSF9TQUZFKGNsaWVudCwgJmV4cC0+Y2xpZW50cywgbmV4 dCwgbmV4dCkgew0KPj4+ICAgICAgICAgICAgY2xpZW50X2Nsb3NlKGNsaWVudCwgdHJ1ZSk7DQo+ Pj4gICAgICAgIH0NCj4+PiAtICAgIG5iZF9leHBvcnRfc2V0X25hbWUoZXhwLCBOVUxMKTsNCj4+ PiAtICAgIG5iZF9leHBvcnRfc2V0X2Rlc2NyaXB0aW9uKGV4cCwgTlVMTCk7DQo+Pj4gKyAgICBp ZiAoZXhwLT5uYW1lKSB7DQo+Pj4gKyAgICAgICAgbmJkX2V4cG9ydF9wdXQoZXhwKTsNCj4+PiAr ICAgICAgICBnX2ZyZWUoZXhwLT5uYW1lKTsNCj4+PiArICAgICAgICBleHAtPm5hbWUgPSBOVUxM Ow0KPj4+ICsgICAgICAgIFFUQUlMUV9SRU1PVkUoJmV4cG9ydHMsIGV4cCwgbmV4dCk7DQo+Pg0K Pj4gZXhwLT5uYW1lIGlzIGFsd2F5cyBub24temVybywgYW5kIF9nZXQgYW5kIF9JTlNFUlRfVEFJ TCB3ZXJlIGRvbmUgaW5kZXBlbmRlbnRseSBmcm9tIG5hbWUsDQo+PiBzbyB3aXRoIHRoZXNlIGZv dXIgbGluZXMgZG9uZSB1bmNvbmRpdGlvbmFsbHk6DQo+PiBSZXZpZXdlZC1ieTogVmxhZGltaXIg U2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPg0KPiANCj4gTm93 LCBvbiB0byB0aGUgYW5hbHlzaXMgb2Ygd2hldGhlciB0aGUgY29kZSBpbiBuYmRfZXhwb3J0X2Ns b3NlKCkgbmVlZHMNCj4gYSBjb25kaXRpb25hbCAtIHllcywgaXQgZG9lcy4gTWFraW5nIGl0IHVu Y29uZGl0aW9uYWwgYnJlYWtzIHRoZSBmYWN0DQo+IHRoYXQgd2UgaGF2ZSBuZXN0ZWQgcmVmZXJl bmNpbmcgc2VtYW50aWNzOiBZb3UgY2FuIGNyZWF0ZSBhbiBleHBvcnQsDQo+IHRoZW4gY2FsbCBu YmRfZXhwb3J0X2dldChleHApIHRvIGhvbGQgYSBzZWNvbmQgcmVmZXJlbmNlIHRvIGl0IGZvciBh cw0KPiBsb25nIGFzIHRoZSBleHBvcnQgcmVtYWlucyBhbGl2ZS4gVGhlIGZpcnN0IHRpbWUgbmJk X2V4cG9ydF9jbG9zZSgpIGlzDQo+IGNhbGxlZCwgeW91IGFyZSB0ZWxsaW5nIHRoZSBOQkQgc2Vy dmVyIHRvIG5vIGxvbmdlciBhZHZlcnRpc2UgdGhlIGV4cG9ydA0KPiAobm8gbmV3IGNsaWVudHMg Y2FuIGNvbm5lY3QsIGJlY2F1c2UgZXhwLT5uYW1lIGlzIG5vdyBOVUxMKSwgYnV0IGFsbA0KPiBl eGlzdGluZyBjbGllbnRzIGNvbnRpbnVlIHRvIGFjY2VzcyB0aGUgZXhwb3J0IGp1c3QgZmluZS4g VGhlIHNlY29uZA0KPiB0aW1lIG5iZF9leHBvcnRfY2xvc2UoKSBpcyBjYWxsZWQsIGV4cC0+bmFt ZSBpcyBhbHJlYWR5IE5VTEwsIGFuZCB3ZSBhcmUNCj4gY2xvc2luZyBvdXQgYWxsIGV4aXN0aW5n IGNsaWVudHMgKGlmIGFueSBhcmUgbGVmdCkgLSBpdCdzIGhvdyB3ZQ0KDQpobSwgbG9va3MgbGlr ZSBpdCB3b3JrcyBpbiBvdGhlciB3YXkNCnZvaWQgbmJkX2V4cG9ydF9jbG9zZShOQkRFeHBvcnQg KmV4cCkNCnsNCiAgICAgTkJEQ2xpZW50ICpjbGllbnQsICpuZXh0Ow0KDQogICAgIG5iZF9leHBv cnRfZ2V0KGV4cCk7DQogICAgIFFUQUlMUV9GT1JFQUNIX1NBRkUoY2xpZW50LCAmZXhwLT5jbGll bnRzLCBuZXh0LCBuZXh0KSB7DQogICAgICAgICBjbGllbnRfY2xvc2UoY2xpZW50LCB0cnVlKTsN CiAgICAgfQ0KICAgICBuYmRfZXhwb3J0X3NldF9uYW1lKGV4cCwgTlVMTCk7DQogICAgIG5iZF9l eHBvcnRfc2V0X2Rlc2NyaXB0aW9uKGV4cCwgTlVMTCk7DQogICAgIG5iZF9leHBvcnRfcHV0KGV4 cCk7DQp9DQoNCmZpcnN0IG9yIHNlY29uZCB0aW1lIHlvdSBjYWxsIGl0LCBpdCB3aWxsIGNsb3Nl IGFsbCBjbGllbnRzLg0KDQo+IGltcGxlbWVudGVkIHRoZSBuYmQtc2VydmVyLXJlbW92ZSBzYWZl IHZzLiBoYXJkIG1vZGUsIGFuZCBob3cgd2UgY291bGQNCj4gYWRkIHRoZSBoaWRlL3NvZnQgbW9k ZXMgaW4gdGhlIGZ1dHVyZSAoc2VlIGJsb2NrLmpzb246TmJkU2VydmVyUmVtb3ZlTW9kZSkuDQo+ IA0KDQphbmQgbmJkX2V4cG9ydF9yZW1vdmUgZG9uJ3QgY2FsbCBuYmRfZXhwb3J0X2Nsb3NlIGlm IGl0IGlzIHNhZmUgbW9kZSBhbmQgdGhlcmUgYXJlIGFjdGl2ZSBjbGllbnRzLg0KDQphaGEsIHJl bWVtYmVyLCB3ZSBkZWNpZGVkIHRvIG5vdCBpbXBsZW1lbnQgbWlkZGxlIG1vZGUsIHdoaWNoIHJl bW92ZXMgZXhwb3J0IGZyb20gdGhlIGxpc3QgYnV0IGtlZXBzDQpleGlzdGluZyBjb25uZWN0aW9u cy4NCg0KDQpCdXQgeW91IGFyZSByaWdodCB0aGF0IGl0IGlzIGF0IGxlYXN0IG5vdCBvYnZpb3Vz LCB0aGF0IG5iZF9leHBvcnRfY2xvc2Ugbm90IGNhbGxlZCB0d2ljZS4uIEFuZCB0aGUgZmFjdA0K dGhhdCBpdCBkZXBlbmRzIG9uIChzZWVtcyB1bnJlbGF0ZWQpIG5hbWUgdmFyaWFibGUgdG9nZXRo ZXIgd2l0aCBuYmRfZXhwb3J0X2Nsb3NlIGNhbGxlZCBmcm9tDQpuYmRfZXhwb3J0X3B1dCBhbmQg ZnJvbSBvdGhlciBwbGFjZXMgKGNvbnNpZGVyIGFsc28gbXkgY29tbWVudCBpbiBuYmRfZXhwb3J0 X3B1dCkgLSB0aGlzIGFsbCBsb29rcyByZWFsbHkNCndlaXJkLCBhbmQgaG9wZSB3ZSdsbCByZWZh Y3RvciBpdCBvbmUgZGF5Lg0KDQpPaywgZm9yIG5vdyBpdCdzIHNhZmUgdG8ga2VlcCBvbGQgY29u ZGl0aW9uLCBzbyBleHAtPm5hbWUgIT0gTlVMTCBpcyBhIHNpZ24gdGhhdCBleHBvcnQgZXhpc3Rz IGluIHRoZSBsaXN0DQooaXQgd29ydGggYSBjb21tZW50LCBhcyBhZnRlciByZW1vdmluZyBuYmRf ZXhwb3J0X3NldF9uYW1lKCkgaXQgYmVjb21lcyBtb3JlIHdlaXJkKSwgYW55d2F5IHBhdGNoIG1h a2VzDQp0aGluZ3MgYmV0dGVyLCBob3BlIHlvdSdsbCBhZGQgYSBjb21tZW50Og0KDQpSZXZpZXdl ZC1ieTogVmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8u Y29tPg0KDQotLSANCkJlc3QgcmVnYXJkcywNClZsYWRpbWlyDQo=