From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] checkpatch: avoid error on cover letter files
Date: Thu, 17 Sep 2020 19:44:21 +0200 [thread overview]
Message-ID: <d5a967e3-ab0d-621f-45fc-d2d4a2bc116b@redhat.com> (raw)
In-Reply-To: <20200917170212.92672-1-sgarzare@redhat.com>
On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> Running checkpatch on a directory that contains a cover letter reports
> this error:
>
> Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
> ERROR: Does not appear to be a unified-diff format patch
>
> total: 1 errors, 0 warnings, 0 lines checked
>
> Let's skip cover letter as it is already done in the Linux kernel.
.. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
ignoring cover-letter logic")."
Maybe complete with that ^^^ ?
Regardless:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index bd3faa154c..3c898f878a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3005,7 +3005,7 @@ sub process {
> return 1;
> }
>
> - if (!$is_patch) {
> + if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
> ERROR("Does not appear to be a unified-diff format patch\n");
> }
>
>
next prev parent reply other threads:[~2020-09-17 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:02 [PATCH] checkpatch: avoid error on cover letter files Stefano Garzarella
2020-09-17 17:44 ` Philippe Mathieu-Daudé [this message]
2020-09-18 7:05 ` Stefano Garzarella
2020-09-18 8:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5a967e3-ab0d-621f-45fc-d2d4a2bc116b@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).