From: Thomas Huth <thuth@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [[PATH for 3.1] v2 18/18] check: Only test usb-ehci when it is compiled in
Date: Wed, 1 Aug 2018 13:47:31 +0200 [thread overview]
Message-ID: <d5aa6904-10d8-32b5-6b12-fde40dc766af@redhat.com> (raw)
In-Reply-To: <20180801110952.5590-19-quintela@redhat.com>
On 08/01/2018 01:09 PM, Juan Quintela wrote:
> The ehci test also test uhci. Welcome to the worderfull world of USB.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> tests/Makefile.include | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f3f8ba48fb..d6f5cc9ccc 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -286,8 +286,10 @@ check-qtest-i386-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
> gcov-files-i386-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
> check-qtest-i386-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
> gcov-files-i386-$(CONFIG_USB_UHCI) += hw/usb/hcd-uhci.c
> +ifeq ($(CONFIG_USB_ECHI)$(CONFIG_USB_UHCI),yy)
> check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
> -gcov-files-i386-y += hw/usb/hcd-ehci.c
> +endif
> +gcov-files-i386-$(CONFIG_USB_EHCI) += hw/usb/hcd-ehci.c
> gcov-files-i386-y += hw/usb/dev-hid.c
> gcov-files-i386-y += hw/usb/dev-storage.c
> check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF)
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2018-08-01 11:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 11:09 [Qemu-devel] [[PATH for 3.1] v2 00/18] Don't "check" disabled drivers Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 01/18] check: Only test vmxnet3 when it is compiled in Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 02/18] check: Only test ne2000 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 03/18] check: Only test eepro100 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 04/18] check: Only test pcnet " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 05/18] check: Only test rtl8139 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 06/18] check: Only test es1370 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 07/18] check: Only test ac97 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 08/18] check: Only test hda " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 09/18] check: Only test ipack " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 10/18] check: Only test ioh3420 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 11/18] check: Only test i82801b11 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 12/18] check: Only test sdhci " Juan Quintela
2018-08-01 15:27 ` no-reply
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 13/18] check: Only test wdt_ib700 " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 14/18] check: Only test pvpanic " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 15/18] check: Only test nvme " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 16/18] check: Only test usb-ohci " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 17/18] check: Only test usb-uhci devices when they are " Juan Quintela
2018-08-01 11:09 ` [Qemu-devel] [[PATH for 3.1] v2 18/18] check: Only test usb-ehci when it is " Juan Quintela
2018-08-01 11:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5aa6904-10d8-32b5-6b12-fde40dc766af@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).