From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egud7-0002rH-KS for qemu-devel@nongnu.org; Wed, 31 Jan 2018 10:48:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egud5-0002gg-1z for qemu-devel@nongnu.org; Wed, 31 Jan 2018 10:48:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1egud4-0002gQ-SD for qemu-devel@nongnu.org; Wed, 31 Jan 2018 10:48:54 -0500 References: <20180131144846.31697-1-armbru@redhat.com> <20180131144846.31697-3-armbru@redhat.com> From: Thomas Huth Message-ID: Date: Wed, 31 Jan 2018 16:48:42 +0100 MIME-Version: 1.0 In-Reply-To: <20180131144846.31697-3-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: f4bug@amsat.org, Fam Zheng On 31.01.2018 15:48, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the change > to target/s390x/gen-features.c manually reverted, and blank lines > around deletions collapsed. Reviewed-by: Thomas Huth I wonder whether it would make sense to add a check based on scripts/clean-includes to patchew already, so that these includes do not sneak in so easily again...? Thomas