From: Thomas Huth <thuth@redhat.com>
To: Ed Maste <emaste@freebsd.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror
Date: Mon, 27 Jul 2020 17:14:57 +0200 [thread overview]
Message-ID: <d5b702de-9066-dc9a-6514-2fcfcda9df55@redhat.com> (raw)
In-Reply-To: <CAPyFy2A-7gLhsCAdAohdnm9BDcHyR2y7EZK2nAKTkp0zYtYC9w@mail.gmail.com>
On 26/07/2020 18.14, Ed Maste wrote:
> On Fri, 24 Jul 2020 at 10:32, Thomas Huth <thuth@redhat.com> wrote:
>>
>> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds,
>> since -Werror is only enabled for Linux and MinGW builds by default. So
>> let's enable them here now, too.
>
> Reviewed-by: Ed Maste <emaste@freebsd.org>
>
> for the FreeBSD change; I'm indifferent on which method is used to
> address the macos deprecation warnings.
Thanks!
I think I'll split the FreeBSD change from the macOS changes, since
macOS apparently needs some more work... (I'll have a try with Daniel's
suggestion to use libsasl2 from Homebrew there...)
Thomas
next prev parent reply other threads:[~2020-07-27 15:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 14:32 [PATCH 0/3] Improve FreeBSD and macOS jobs in the Cirrus-CI Thomas Huth
2020-07-24 14:32 ` [PATCH 1/3] configure: Fix atomic64 test for --enable-werror on macOS Thomas Huth
2020-07-24 15:01 ` Christian Schoenebeck
2020-07-27 13:14 ` Alex Bennée
2020-07-24 14:32 ` [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror Thomas Huth
2020-07-24 14:46 ` Daniel P. Berrangé
2020-07-24 16:46 ` Philippe Mathieu-Daudé
2020-07-24 16:49 ` Daniel P. Berrangé
2020-07-27 5:44 ` Thomas Huth
2020-07-27 8:30 ` Peter Maydell
2020-07-27 8:45 ` Thomas Huth
2020-07-24 16:50 ` Peter Maydell
2020-07-24 17:21 ` Christian Schoenebeck
2020-07-27 10:57 ` Daniel P. Berrangé
2020-07-28 6:43 ` Thomas Huth
2020-07-28 10:02 ` Daniel P. Berrangé
2020-07-24 15:01 ` Peter Maydell
2020-07-26 16:14 ` Ed Maste
2020-07-26 17:19 ` Christian Schoenebeck
2020-07-27 15:14 ` Thomas Huth [this message]
2020-07-24 14:32 ` [PATCH 3/3] cirrus.yml: Update the macOS jobs to Catalina Thomas Huth
2020-07-26 16:18 ` Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b702de-9066-dc9a-6514-2fcfcda9df55@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=emaste@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).