From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwgZB-00030E-1d for qemu-devel@nongnu.org; Mon, 25 Sep 2017 23:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwgZ6-0004AO-Lu for qemu-devel@nongnu.org; Mon, 25 Sep 2017 23:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54268) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwgZ6-00049P-DT for qemu-devel@nongnu.org; Mon, 25 Sep 2017 23:29:44 -0400 References: <1506071794-4373-1-git-send-email-thuth@redhat.com> <20170925135316.74fed6da.cohuck@redhat.com> <20170925133153.GZ3030@localhost.localdomain> <20170925154647.357047b9@nial.brq.redhat.com> <20170925143439.GA3030@localhost.localdomain> <59e890ab-45e4-fe8a-a8de-3c441de19080@redhat.com> <20170925175944.GD3030@localhost.localdomain> <20170926025956.GB4115@localhost.localdomain> From: Thomas Huth Message-ID: Date: Tue, 26 Sep 2017 05:29:12 +0200 MIME-Version: 1.0 In-Reply-To: <20170926025956.GB4115@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Peter Maydell Cc: Igor Mammedov , Cornelia Huck , QEMU Developers , Paolo Bonzini , Xiao Guangrong , "Michael S. Tsirkin" , Marcel Apfelbaum , Christian Borntraeger , Gerd Hoffmann , Stefano Stabellini , Anthony Perard , David Hildenbrand , David Gibson , Bharata B Rao , Amit Shah On 26.09.2017 04:59, Eduardo Habkost wrote: > On Mon, Sep 25, 2017 at 07:05:26PM +0100, Peter Maydell wrote: >> On 25 September 2017 at 18:59, Eduardo Habkost w= rote: >>> Finding the full list of devices that can be instantiated >>> internally at hotplug-time sounds tricky. >> >> If we just diff "list of devices marked hotplug before this patch" >> against "list of devices marked hotplug after this patch" how >> big is the list? Can we just eyeball it to see what needs >> to be specialcased? >=20 > So, the full list quite big, ~1800 device types are affected by > this patch: >=20 > https://gist.github.com/ehabkost/bd8e25c6811ac81d947ad8ad5b557f5c#file-= dev-types-diff-json >=20 > If we ignore the "-cpu" classes, there ~640 affected device > types. >=20 > However, if we look only at the direct children of TYPE_DEVICE, > we have: OK, thanks a lot for that list! But do you think that we can assume that the devices which are not direct children of TYPE_DEVICE can not be hotplugged internally during runtime? ... I currently don't think so (but at least they are good candidates which need to be examined more carefully). But anyway, how can we continue here? Set hotpluggable =3D true on all 64= 0 (or even all 1800) affected devices? That sounds very, very ugly to me. Maybe we should just do it for the virtio-*-device devices and the others that break during "make check" (btw. sorry for not noticing this ... I normally run "make check" regularly, but this time I apparently missed to run it for aarch64), and if we later notice some more problems, we know that we lack a "make check" test for that case, too, and we should add such a test? That would at least eventually improve our test coverage a little bit, I guess... Thomas