From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Marcel Holtmann <marcel@holtmann.org>,
qemu-devel@nongnu.org, mst@redhat.com, xieyongji@bytedance.com
Subject: Re: [PATCH v2 06/10] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant
Date: Tue, 20 Dec 2022 22:50:02 +0100 [thread overview]
Message-ID: <d5dd2d56-d717-a13f-237e-372f7ba9c4bb@linaro.org> (raw)
In-Reply-To: <f0653315f8d27ec85e02504fdb7f282921d9743d.1671563795.git.marcel@holtmann.org>
On 20/12/22 20:27, Marcel Holtmann wrote:
> The assignment of dev->postcopy_ufd can be moved into an else clause and
> then the code becomes C90 compliant.
>
> CC libvhost-user.o
> libvhost-user.c: In function ‘vu_set_postcopy_advise’:
> libvhost-user.c:1625:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> 1625 | struct uffdio_api api_struct;
> | ^~~~~~
>
> Understandable, it might be desired to avoid else clauses, but in this
> case it seems clear enough and frankly the dev->postcopy_ufd is only
> assigned once.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> subprojects/libvhost-user/libvhost-user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-12-20 21:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 19:27 [PATCH v2 00/10] Compiler warning fixes for libvhost-user,libvduse Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 01/10] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 02/10] libvhost-user: Replace typeof with __typeof__ Marcel Holtmann
2022-12-20 21:48 ` Philippe Mathieu-Daudé
2022-12-20 19:27 ` [PATCH v2 03/10] libvhost-user: Cast rc variable to avoid compiler warning Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 04/10] libvhost-user: Use unsigned int i for some for-loop iterations Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 05/10] libvhost-user: Declare uffdio_register early to make it C90 compliant Marcel Holtmann
2022-12-20 21:49 ` Philippe Mathieu-Daudé
2022-12-20 19:27 ` [PATCH v2 06/10] libvhost-user: Change dev->postcopy_ufd assignment " Marcel Holtmann
2022-12-20 21:50 ` Philippe Mathieu-Daudé [this message]
2022-12-20 19:27 ` [PATCH v2 07/10] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 08/10] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-20 19:27 ` [PATCH v2 09/10] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq Marcel Holtmann
2022-12-21 11:32 ` Yongji Xie
2022-12-20 19:27 ` [RFC v2 10/10] libvduse: Fix assignment in vring_set_avail_event Marcel Holtmann
2022-12-21 11:44 ` Yongji Xie
2022-12-21 13:08 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5dd2d56-d717-a13f-237e-372f7ba9c4bb@linaro.org \
--to=philmd@linaro.org \
--cc=marcel@holtmann.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).