From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] meson: remove system/internal distinction for libfdt
Date: Tue, 7 May 2024 09:40:45 +0200 [thread overview]
Message-ID: <d5e37b1f-fac0-48ff-ae47-59090b5b50c0@linaro.org> (raw)
In-Reply-To: <20240507071948.105022-2-pbonzini@redhat.com>
On 7/5/24 09:19, Paolo Bonzini wrote:
> Treat libfdt like slirp and the other dependencies that use --enable-download;
> remove the ability to force usage of the subproject.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> meson.build | 69 +++++++++++++++--------------------
> meson_options.txt | 6 +--
> scripts/meson-buildoptions.sh | 4 +-
> 3 files changed, 34 insertions(+), 45 deletions(-)
> diff --git a/meson_options.txt b/meson_options.txt
> index adc77bae0cd..90902c19d1c 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -308,9 +308,9 @@ option('vduse_blk_export', type: 'feature', value: 'auto',
>
> option('capstone', type: 'feature', value: 'auto',
> description: 'Whether and how to find the capstone library')
> -option('fdt', type: 'combo', value: 'auto',
> - choices: ['disabled', 'enabled', 'auto', 'system', 'internal'],
> - description: 'Whether and how to find the libfdt library')
> +option('fdt', type: 'feature', value: 'auto',
> + deprecated: { 'system': 'enabled' },
TIL deprecated options:
https://mesonbuild.com/Build-options.html#deprecated-options
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-05-07 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 7:19 [PATCH 0/4] express dependency of individual boards on libfdt Paolo Bonzini
2024-05-07 7:19 ` [PATCH 1/4] meson: remove system/internal distinction for libfdt Paolo Bonzini
2024-05-07 7:40 ` Philippe Mathieu-Daudé [this message]
2024-05-07 7:19 ` [PATCH 2/4] kconfig: express dependency of individual boards on libfdt Paolo Bonzini
2024-05-07 7:48 ` Philippe Mathieu-Daudé
2024-05-07 10:25 ` Paolo Bonzini
2024-05-07 7:19 ` [PATCH 3/4] hw/xtensa: require libfdt Paolo Bonzini
2024-05-07 7:34 ` Philippe Mathieu-Daudé
2024-05-07 7:19 ` [PATCH 4/4] configs: disable emulators that require it if libfdt is not found Paolo Bonzini
2024-05-07 7:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e37b1f-fac0-48ff-ae47-59090b5b50c0@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).