From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E098AC433E3 for ; Fri, 24 Jul 2020 16:59:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA0732067D for ; Fri, 24 Jul 2020 16:59:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fPXp5dCw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA0732067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz12S-0006Gl-UQ for qemu-devel@archiver.kernel.org; Fri, 24 Jul 2020 12:59:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jz11o-0005Sz-8b for qemu-devel@nongnu.org; Fri, 24 Jul 2020 12:58:36 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:52261 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jz11l-0004za-OG for qemu-devel@nongnu.org; Fri, 24 Jul 2020 12:58:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595609912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14b4Siv7jvAtJ+zVkMip/Yz5y5dPJosY7/rJYacl9KY=; b=fPXp5dCwLsL8Jmm/7/gOiGrSNM8kbm1XEzJLadHCe7IiugqjOhk3qA2CTgPcoCGy8yyCcA bppwQDINgRs6tbYPul08L838qFXs/jHAgDy0aZBXQQaIt2redwhQoMuep4IGNQFzcLDweU I0uLlLtJeACsnuas2cCilr7TDt6FzDI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-nGavwGWKPMqiui_mv4IsJg-1; Fri, 24 Jul 2020 12:58:30 -0400 X-MC-Unique: nGavwGWKPMqiui_mv4IsJg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33A0EC7465 for ; Fri, 24 Jul 2020 16:58:29 +0000 (UTC) Received: from ibm-p8-OVS-01-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com (ovpn-120-206.rdu2.redhat.com [10.10.120.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id E993E74F64; Fri, 24 Jul 2020 16:58:28 +0000 (UTC) Subject: Re: [PATCH 3/3] scripts/qmp/qom-fuse: Fix getattr(), read() for files in / To: Markus Armbruster , qemu-devel@nongnu.org References: <20200723142738.1868568-1-armbru@redhat.com> <20200723142738.1868568-4-armbru@redhat.com> From: John Snow Message-ID: Date: Fri, 24 Jul 2020 12:58:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200723142738.1868568-4-armbru@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 06:44:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/23/20 10:27 AM, Markus Armbruster wrote: > path, prop = "type".rsplit('/', 1) sets path to "", which doesn't > work. Correct to "/". > BOTD. If it works for you, that's good news. Reviewed-by: John Snow > Signed-off-by: Markus Armbruster > --- > scripts/qmp/qom-fuse | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse > index 405e6ebd67..7c7cff8edf 100755 > --- a/scripts/qmp/qom-fuse > +++ b/scripts/qmp/qom-fuse > @@ -45,8 +45,10 @@ class QOMFS(Operations): > return False > > def is_property(self, path): > + path, prop = path.rsplit('/', 1) > + if path == '': > + path = '/' > try: > - path, prop = path.rsplit('/', 1) > for item in self.qmp.command('qom-list', path=path): > if item['name'] == prop: > return True > @@ -55,8 +57,10 @@ class QOMFS(Operations): > return False > > def is_link(self, path): > + path, prop = path.rsplit('/', 1) > + if path == '': > + path = '/' > try: > - path, prop = path.rsplit('/', 1) > for item in self.qmp.command('qom-list', path=path): > if item['name'] == prop: > if item['type'].startswith('link<'): > @@ -71,6 +75,8 @@ class QOMFS(Operations): > return -ENOENT > > path, prop = path.rsplit('/', 1) > + if path == '': > + path = '/' > try: > data = self.qmp.command('qom-get', path=path, property=prop) > data += '\n' # make values shell friendly >