From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCpmi-0006IK-O9 for qemu-devel@nongnu.org; Wed, 17 Oct 2018 13:39:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCpmd-0002tJ-RG for qemu-devel@nongnu.org; Wed, 17 Oct 2018 13:39:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60914) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCpmd-0002su-KE for qemu-devel@nongnu.org; Wed, 17 Oct 2018 13:38:59 -0400 References: <20181016232201.16829-1-crosa@redhat.com> <20181017162944.GF31060@habkost.net> From: Cleber Rosa Message-ID: Date: Wed, 17 Oct 2018 13:38:53 -0400 MIME-Version: 1.0 In-Reply-To: <20181017162944.GF31060@habkost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Acceptance tests: host arch to target arch name mapping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Peter Maydell Cc: QEMU Developers , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Caio Carrara On 10/17/18 12:29 PM, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 01:34:41PM +0100, Peter Maydell wrote: >> On 17 October 2018 at 00:22, Cleber Rosa wrote: >>> The host arch name is not always the target arch name, so it's >>> necessary to have a mapping. >>> >>> The configure scripts contains what is the authoritative and failproof >>> mapping, but, reusing it is not straightforward, so it's replicated in >>> the acceptance tests supporting code. >> >> So, why does the test code need to care? It's not clear >> from the patch... My expectation would be that you'd >> just test all the testable target architectures, >> regardless of what the host architecture is. > > I tend to agree. Maybe the right solution is to get rid of the > os.uname(). I think the default should be testing all QEMU > binaries that were built, and the host architecture shouldn't > matter. > I'm in favor of exercising all built targets, but that seems to me to be on another layer, above the test themselves. This change is about the behavior of a test when not told about the target arch (and thus binary) it should use. > That said, I think the dictionary is a nice temporary workaround > until we fix that. > I think even with a switch towards "use the target(s) built", we'd still need to pick one at the test execution level. A job may include running the same test with different targets, though. So, I'm not sure this would be just temporary. - Cleber.