Re: [PATCH v2 33/42] audio: move internal APIs to audio_int.h

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 22/10/25 08:56, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   audio/audio.h          | 21 ---------------------
>   audio/audio_int.h      | 22 ++++++++++++++++++++++
>   audio/audio-hmp-cmds.c |  2 +-
>   audio/wavcapture.c     |  2 +-
>   4 files changed, 24 insertions(+), 23 deletions(-)


> diff --git a/audio/audio_int.h b/audio/audio_int.h
> index 4a4d69f2bf..cc7a6fe087 100644
> --- a/audio/audio_int.h
> +++ b/audio/audio_int.h
> @@ -29,12 +29,16 @@
>   #define FLOAT_MIXENG
>   /* #define RECIPROCAL */
>   #endif
> +#include "audio.h"
>   #include "mixeng.h"
>   
>   #ifdef CONFIG_GIO
>   #include <gio/gio.h>
>   #endif
>   
> +void AUD_vlog (const char *cap, const char *fmt, va_list ap) G_GNUC_PRINTF(2, 0);
> +void AUD_log (const char *cap, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
> +
>   struct audio_pcm_ops;
>   
>   struct audio_callback {
> @@ -187,6 +191,24 @@ struct audio_pcm_ops {
>       void   (*volume_in)(HWVoiceIn *hw, Volume *vol);
>   };
>   
> +audsettings audiodev_to_audsettings(AudiodevPerDirectionOptions *pdo);
> +int audioformat_bytes_per_sample(AudioFormat fmt);
> +int audio_buffer_frames(AudiodevPerDirectionOptions *pdo,
> +                        audsettings *as, int def_usecs);
> +int audio_buffer_samples(AudiodevPerDirectionOptions *pdo,
> +                         audsettings *as, int def_usecs);
> +int audio_buffer_bytes(AudiodevPerDirectionOptions *pdo,
> +                       audsettings *as, int def_usecs);
> +
> +static inline void *advance (void *p, int incr)
> +{
> +    uint8_t *d = p;
> +    return (d + incr);
> +}

Modulo checkpatch.pl errors,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>