From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqCi-0006Og-1H
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 13:42:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqCd-0003vV-Te
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 13:42:03 -0400
Received: from mail-oi0-x236.google.com ([2607:f8b0:4003:c06::236]:33769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1brqCd-0003uz-Op
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 13:41:59 -0400
Received: by mail-oi0-x236.google.com with SMTP id r126so281895224oib.0
	for <qemu-devel@nongnu.org>; Wed, 05 Oct 2016 10:41:59 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-29-git-send-email-rth@twiddle.net>
	<87bmyysyl3.fsf@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <d5f3fd55-c2b5-9122-e10b-001102f6e272@twiddle.net>
Date: Wed, 5 Oct 2016 10:41:56 -0700
MIME-Version: 1.0
In-Reply-To: <87bmyysyl3.fsf@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 28/35] target-arm: emulate LL/SC using
 cmpxchg helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Emilio G. Cota" <cota@braap.org>

On 10/05/2016 06:40 AM, Alex Bennée wrote:
> I thought you added some of the text back, or is that in a private
> re-work branch for v5?
>
>   Added back
>
>   /* Load/Store exclusive instructions are implemented by remembering
>      the value/address loaded, and seeing if these are the same
>      when the store is performed.  This should be sufficient to implement
>      the architecturally mandated semantics, and avoids having to monitor
>      regular stores.  The compare vs the remembered value is done during
>      the cmpxchg operation, but we must compare the addresses manually.  */

I did, I swear.  But I certainly don't see that now.  I can only assume some 
sort of horrible user error overwriting a branch.  How annoying.


r~