From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/26] target/arm: Honour M-profile FP enable bits
Date: Tue, 23 Apr 2019 11:19:23 -0700 [thread overview]
Message-ID: <d5f58c94-3122-9c65-6f6f-18d19acbad8d@linaro.org> (raw)
In-Reply-To: <20190416125744.27770-6-peter.maydell@linaro.org>
On 4/16/19 5:57 AM, Peter Maydell wrote:
> Like AArch64, M-profile floating point has no FPEXC enable
> bit to gate floating point; so always set the VFPEN TB flag.
>
> M-profile also has CPACR and NSACR similar to A-profile;
> they behave slightly differently:
> * the CPACR is banked between Secure and Non-Secure
> * if the NSACR forces a trap then this is taken to
> the Secure state, not the Non-Secure state
>
> Honour the CPACR and NSACR settings. The NSACR handling
> requires us to borrow the exception.target_el field
> (usually meaningless for M profile) to distinguish the
> NOCP UsageFault taken to Secure state from the more
> usual fault taken to the current security state.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/helper.c | 55 +++++++++++++++++++++++++++++++++++++++---
> target/arm/translate.c | 10 ++++++--
> 2 files changed, 60 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-04-23 18:19 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 12:57 [Qemu-devel] [PATCH 00/26] target/arm: Implement M profile floating point Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-16 12:57 ` [Qemu-devel] [PATCH 01/26] target/arm: Make sure M-profile FPSCR RES0 bits are not settable Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 17:25 ` Richard Henderson
2019-04-23 17:25 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 02/26] hw/intc/armv7m_nvic: Allow reading of M-profile MVFR* registers Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 17:27 ` Richard Henderson
2019-04-23 17:27 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 03/26] target/arm: Implement dummy versions of M-profile FP-related registers Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 17:55 ` Richard Henderson
2019-04-23 17:55 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 04/26] target/arm: Disable most VFP sysregs for M-profile Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 18:08 ` Richard Henderson
2019-04-23 18:08 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 05/26] target/arm: Honour M-profile FP enable bits Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 18:19 ` Richard Henderson [this message]
2019-04-23 18:19 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 06/26] target/arm: Decode FP instructions for M profile Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 18:37 ` Richard Henderson
2019-04-23 18:37 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 07/26] target/arm: Clear CONTROL_S.SFPA in SG insn if FPU present Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 20:58 ` Richard Henderson
2019-04-23 20:58 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 08/26] target/arm: Handle SFPA and FPCA bits in reads and writes of CONTROL Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 21:33 ` Richard Henderson
2019-04-23 21:33 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 09/26] target/arm/helper: don't return early for STKOF faults during stacking Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 21:46 ` Richard Henderson
2019-04-23 21:46 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 10/26] target/arm: Handle floating point registers in exception entry Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 22:21 ` Richard Henderson
2019-04-23 22:21 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 11/26] target/arm: Implement v7m_update_fpccr() Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-16 12:57 ` [Qemu-devel] [PATCH 12/26] target/arm: Clear CONTROL.SFPA in BXNS and BLXNS Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 22:50 ` Richard Henderson
2019-04-23 22:50 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 13/26] target/arm: Clean excReturn bits when tail chaining Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 22:54 ` Richard Henderson
2019-04-23 22:54 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 14/26] target/arm: Allow for floating point in callee stack integrity check Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 23:04 ` Richard Henderson
2019-04-23 23:04 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 15/26] target/arm: Handle floating point registers in exception return Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 23:29 ` Richard Henderson
2019-04-23 23:29 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 16/26] target/arm: Move NS TBFLAG from bit 19 to bit 6 Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 23:47 ` Richard Henderson
2019-04-23 23:47 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 17/26] target/arm: Overlap VECSTRIDE and XSCALE_CPAR TB flags Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-23 23:51 ` Richard Henderson
2019-04-23 23:51 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 18/26] target/arm: Set FPCCR.S when executing M-profile floating point insns Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 0:00 ` Richard Henderson
2019-04-24 0:00 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 19/26] target/arm: Activate M-profile floating point context when FPCCR.ASPEN is set Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 0:08 ` Richard Henderson
2019-04-24 0:08 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 20/26] target/arm: New helper function arm_v7m_mmu_idx_all() Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 0:12 ` Richard Henderson
2019-04-24 0:12 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 21/26] target/arm: New function armv7m_nvic_set_pending_lazyfp() Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 1:10 ` Richard Henderson
2019-04-24 1:10 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 22/26] target/arm: Add lazy-FP-stacking support to v7m_stack_write() Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 1:27 ` Richard Henderson
2019-04-24 1:27 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 23/26] target/arm: Implement M-profile lazy FP state preservation Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 2:04 ` Richard Henderson
2019-04-24 2:04 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 24/26] target/arm: Implement VLSTM for v7M CPUs with an FPU Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 2:17 ` Richard Henderson
2019-04-24 2:17 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 25/26] target/arm: Implement VLLDM " Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 2:21 ` Richard Henderson
2019-04-24 2:21 ` Richard Henderson
2019-04-16 12:57 ` [Qemu-devel] [PATCH 26/26] target/arm: Enable FPU for Cortex-M4 and Cortex-M33 Peter Maydell
2019-04-16 12:57 ` Peter Maydell
2019-04-24 2:25 ` Richard Henderson
2019-04-24 2:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5f58c94-3122-9c65-6f6f-18d19acbad8d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).