From: Richard Henderson <richard.henderson@linaro.org>
To: Roman Kiryanov <rkir@google.com>, qemu-devel@nongnu.org
Cc: jansene@google.com, mett@google.com, jpcottin@google.com
Subject: Re: [PATCH 1/3] exec: Make the MemOp enum cast explicit
Date: Tue, 18 Jun 2024 15:59:32 -0700 [thread overview]
Message-ID: <d5f66c67-8a2b-4a68-8a96-ef0e4ffb49f7@linaro.org> (raw)
In-Reply-To: <20240618224528.878425-1-rkir@google.com>
On 6/18/24 15:45, Roman Kiryanov wrote:
> to use the QEMU headers with a C++ compiler.
>
> Google-Bug-Id: 331190993
> Change-Id: I785f2e65d192287f1f964d2840131b653755648c
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> include/exec/memop.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/memop.h b/include/exec/memop.h
> index 06417ff361..f881fe7af4 100644
> --- a/include/exec/memop.h
> +++ b/include/exec/memop.h
> @@ -161,7 +161,7 @@ static inline MemOp size_memop(unsigned size)
> /* Power of 2 up to 8. */
> assert((size & (size - 1)) == 0 && size >= 1 && size <= 8);
> #endif
> - return ctz32(size);
> + return (MemOp)ctz32(size);
> }
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-06-18 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 22:45 [PATCH 1/3] exec: Make the MemOp enum cast explicit Roman Kiryanov
2024-06-18 22:59 ` Richard Henderson [this message]
2024-06-19 10:40 ` Philippe Mathieu-Daudé
2024-06-19 10:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5f66c67-8a2b-4a68-8a96-ef0e4ffb49f7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=mett@google.com \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).