From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Keith Packard <keithp@keithp.com>
Cc: qemu-devel@nongnu.org, Chris Wulff <crwulff@gmail.com>,
Marek Vasut <marex@denx.de>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] target/nios2: Fix semihost lseek offset computation
Date: Tue, 1 Aug 2023 15:23:52 +0200 [thread overview]
Message-ID: <d5fac15f-3ab9-42d4-ad39-95c500c4417a@linaro.org> (raw)
In-Reply-To: <CAFEAcA8Q_qjJV55v0M4LwuK-2tuM4DaBVsmP5vAVogt8Hq98vg@mail.gmail.com>
On 1/8/23 14:06, Peter Maydell wrote:
> On Tue, 1 Aug 2023 at 00:53, Keith Packard via <qemu-devel@nongnu.org> wrote:
>>
>> The arguments for deposit64 are (value, start, length, fieldval); this
>> appears to have thought they were (value, fieldval, start,
>> length). Reorder the parameters to match the actual function.
>>
>> Signed-off-by: Keith Packard <keithp@keithp.com>
>> ---
>> target/nios2/nios2-semi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi.c
>> index ffd1f095f6..fc1df1dfeb 100644
>> --- a/target/nios2/nios2-semi.c
>> +++ b/target/nios2/nios2-semi.c
>> @@ -170,7 +170,7 @@ void do_nios2_semihosting(CPUNios2State *env)
>> GET_ARG64(2);
>> GET_ARG64(3);
>> semihost_sys_lseek(cs, nios2_semi_u64_cb, arg0,
>> - deposit64(arg2, arg1, 32, 32), arg3);
>> + deposit64(arg2, 32, 32, arg1), arg3);
>> break;
>>
>> case HOSTED_RENAME:
>
> Fixes: d1e23cbaa403b2d ("target/nios2: Use semihosting/syscalls.h")
> Cc: qemu-stable@nongnu.org
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Commit 950272506d ("target/m68k: Use semihosting/syscalls.h") has the
same issue.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-01 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 23:52 [PATCH] target/nios2: Fix semihost lseek offset computation Keith Packard via
2023-08-01 12:06 ` Peter Maydell
2023-08-01 13:23 ` Philippe Mathieu-Daudé [this message]
2023-08-01 21:46 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5fac15f-3ab9-42d4-ad39-95c500c4417a@linaro.org \
--to=philmd@linaro.org \
--cc=crwulff@gmail.com \
--cc=keithp@keithp.com \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).