From: Max Reitz <mreitz@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Florian Florensa <fflorensa@online.net>,
Jason Dillaman <dillaman@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[]
Date: Tue, 15 Sep 2020 11:04:33 +0200 [thread overview]
Message-ID: <d5fbc719-9ec5-dd03-b5ba-2e63c97b3a9e@redhat.com> (raw)
In-Reply-To: <20200914190553.74871-1-sgarzare@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]
On 14.09.20 21:05, Stefano Garzarella wrote:
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is a strong
> option since it can changes the data of a BDS.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1821528
> Fixes: 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> Cc: Florian Florensa <fflorensa@online.net>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-15 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 19:05 [PATCH] block/rbd: add 'namespace' to qemu_rbd_strong_runtime_opts[] Stefano Garzarella
2020-09-14 19:15 ` Jason Dillaman
2020-09-15 9:04 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5fbc719-9ec5-dd03-b5ba-2e63c97b3a9e@redhat.com \
--to=mreitz@redhat.com \
--cc=dillaman@redhat.com \
--cc=fflorensa@online.net \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).