From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com
Cc: qemu-arm@nongnu.org, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface
Date: Tue, 9 Jan 2024 14:30:52 -0600 [thread overview]
Message-ID: <d5fc4e81-cb00-4bbf-986c-2541fda61742@linux.ibm.com> (raw)
In-Reply-To: <e09b5baa-8147-4450-a899-e015a9fd0f35@kaod.org>
Hello Cedric,
>>>> + for (i = 0; i < ASPEED_FSI_NUM; i++) {
>>>> + if (!qdev_realize_and_unref(DEVICE(&s->fsi[i]),
>>>> BUS(&s->opb[i]),
>>>
>>>
>>> s->fsi[i] is not allocated. We should use qdev_realize instead.
>>
>> I am not sure I understood this. FSIMasterState fsi[ASPEED_FSI_NUM];
>> is inside structure AspeedAPB2OPBState so it must be allocated, right?
>
> See the documentation :
>
> https://www.qemu.org/docs/master/devel/qdev-api.html#c.qdev_realize_and_unref
Fixed it. Thanks for the review.
Regards,
Ninad
next prev parent reply other threads:[~2024-01-09 20:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 23:56 [PATCH v8 00/10] Introduce model for IBM's FSI Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 01/10] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-12-12 14:46 ` Cédric Le Goater
2024-01-09 19:23 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 02/10] hw/fsi: Introduce IBM's FSI Bus Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave,scratchpad Ninad Palsule
2023-12-12 14:48 ` Cédric Le Goater
2024-01-09 22:08 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 04/10] hw/fsi: IBM's On-chip Peripheral Bus Ninad Palsule
2023-12-12 14:48 ` Cédric Le Goater
2024-01-08 22:49 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 05/10] hw/fsi: Introduce IBM's FSI master Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2024-01-09 20:12 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2024-01-08 22:39 ` Ninad Palsule
2024-01-09 7:38 ` Cédric Le Goater
2024-01-09 20:30 ` Ninad Palsule [this message]
2023-11-28 23:56 ` [PATCH v8 07/10] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2023-11-28 23:56 ` [PATCH v8 08/10] hw/fsi: Added qtest Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 09/10] hw/fsi: Added FSI documentation Ninad Palsule
2023-11-28 23:57 ` [PATCH v8 10/10] hw/fsi: Update MAINTAINER list Ninad Palsule
2024-01-10 7:44 ` [PATCH v8 00/10] Introduce model for IBM's FSI Cédric Le Goater
2024-01-10 23:17 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5fc4e81-cb00-4bbf-986c-2541fda61742@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).