qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	LEROY Christophe <christophe.leroy@csgroup.eu>,
	Greg Kurz <groug@kaod.org>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] hw/ppc/ppc405_boards: Change kernel load address
Date: Wed, 8 Dec 2021 14:07:09 +0100	[thread overview]
Message-ID: <d6005c8e-d007-2a66-00f3-5f9d3f30e420@redhat.com> (raw)
In-Reply-To: <f29e3aba-a1d7-484d-2aa2-b676113c4f43@kaod.org>

On 03/12/2021 13.25, Cédric Le Goater wrote:
> On 12/3/21 11:40, Peter Maydell wrote:
>> On Fri, 3 Dec 2021 at 10:32, Thomas Huth <thuth@redhat.com> wrote:
>>> I guess it's an accidential NULL pointer dereference somewhere in the u-boot
>>> code ... which will be quite hard to track down when the first page of
>>> memory is marked as writable... :-/
>>
>> Attach a target-arch gdb to the QEMU gdbstub and put a watchpoint on
>> address zero ? (Or if you suspect something inside QEMU is doing it
>> then run QEMU under gdb and watchpoint the host memory location
>> corresponding to guest address 0, but that's more painful.) Nothing
>> in the pre-kernel part of the boot process will have set up paging,
>> so the watchpointing should be pretty reliable.
> 
> That's the guy:
> 
>    
> https://gitlab.com/huth/u-boot/-/blob/taihu/arch/powerpc/cpu/ppc4xx/sdram.c#L199 
> 
> 
> There must be an error in how get_ram_size() restores the RAM values :
> 
>    https://gitlab.com/huth/u-boot/-/blob/taihu/common/memsize.c

There is definitely something wrong in that function. Seems like they tried 
to fix it once here:

  https://source.denx.de/u-boot/u-boot/-/commit/b8496cced856ff411f

but that patch got later reverted without a replacement later...

  Thomas




  reply	other threads:[~2021-12-08 13:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 19:14 [PATCH] hw/ppc/ppc405_boards: Change kernel load address Cédric Le Goater
2021-12-02 19:17 ` Thomas Huth
2021-12-02 19:19   ` Cédric Le Goater
2021-12-02 19:32     ` LEROY Christophe
2021-12-03 10:27       ` Cédric Le Goater
2021-12-03 10:31         ` Thomas Huth
2021-12-03 10:40           ` Peter Maydell
2021-12-03 12:25             ` Cédric Le Goater
2021-12-08 13:07               ` Thomas Huth [this message]
2021-12-08 13:15                 ` Cédric Le Goater
2021-12-08 13:19                   ` Thomas Huth
2021-12-08 16:54                     ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6005c8e-d007-2a66-00f3-5f9d3f30e420@redhat.com \
    --to=thuth@redhat.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).