From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4868AC2B9F4 for ; Mon, 28 Jun 2021 15:24:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 025A861457 for ; Mon, 28 Jun 2021 15:24:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 025A861457 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxt85-000535-LE for qemu-devel@archiver.kernel.org; Mon, 28 Jun 2021 11:24:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxt6s-00045K-SR for qemu-devel@nongnu.org; Mon, 28 Jun 2021 11:23:42 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:44679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxt6q-00060D-OY for qemu-devel@nongnu.org; Mon, 28 Jun 2021 11:23:42 -0400 Received: by mail-pg1-x532.google.com with SMTP id u14so9287085pga.11 for ; Mon, 28 Jun 2021 08:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=EM75SH72X6nzVFHlkR2fXFfltgBEftsK66XNTB1+8h0=; b=ObcNXqD1fNMIyJKxT1JmJv8duHRjnyGkbfGN8Kb01YyfOEJH6UouqVEiTqTtCDs8hB 0jYdXVfK1K/HbovorrxVloFv9mA2YQ0aUwOoxjntDcyN66RBo/FXFqOc45hURjgs13C3 Vv6AaCeMj6/5pK09VClR6duaeSS31uIra0z65AwDKr8IOnOs7Ojc47EHo8Yzk5h9i3dH IbCzkP/V19P1ubZ64kkL6llRuVJVWyCRWYVUHPX1LgzLplQrYO0ThPBZAeFWFuJN4Cba p+DI3Kh9UNZHmyc5HReL+V/mkNGNswaNfiir4Yt2QPVt7LO+8JdZ9HgjKA6u7QVsba7y Nqww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EM75SH72X6nzVFHlkR2fXFfltgBEftsK66XNTB1+8h0=; b=arObypwLW+bosTxwqz1A+A6xdNL3L+hzZDYx6XoJ64wTnwgCJRfbZER/iU/3gD9yOp t6pXoLPg3Nb94lZcwyhLejikis8HuPC+D+LFioulDHOzf2GUZ7v5gGnhGEMXTEfB/bac piah3+AQ0w3Iesz33N8Z+EKU1Yg/ePfoZdG4Aq3nadfcwFb8yr33hwXGzOzA83cRwXob lOM6TjAknhKd6T7+gqL3m9C42e0jYbJEd8Y/ghDqCl0wxF4U2xAo+c5ajFbu+/GZ1GQK ie6vMc/m+qX1giVwdz9wgOneE6qFAFcm4TG8TS5ZKss72t4SK+KSOMB/CeZWDkBM82WL zkeg== X-Gm-Message-State: AOAM5336paFlIuLcuqxmGX6+t1ajUZyInmyer3pWMAoLGug/V6WjYb7g XmZzDarrYwcFMmE2kl4vjzlWSpQbcYnLBw== X-Google-Smtp-Source: ABdhPJyYvzqQ2PRiluKHBpRjTUNBXOK9daGTjczPeAiu8NjtVxvr3u5j1FMmdpol2+O2SdxdGSzgRw== X-Received: by 2002:a62:3244:0:b029:308:22b0:52ff with SMTP id y65-20020a6232440000b029030822b052ffmr23063528pfy.68.1624893819369; Mon, 28 Jun 2021 08:23:39 -0700 (PDT) Received: from [192.168.1.11] ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id v11sm26820pjs.13.2021.06.28.08.23.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 08:23:39 -0700 (PDT) Subject: Re: [PATCH 05/18] target/arm: Use dup_const() instead of bitfield_replicate() To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210628135835.6690-1-peter.maydell@linaro.org> <20210628135835.6690-6-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Mon, 28 Jun 2021 08:23:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210628135835.6690-6-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/28/21 6:58 AM, Peter Maydell wrote: > Use dup_const() instead of bitfield_replicate() in > disas_simd_mod_imm(). > > (We can't replace the other use of bitfield_replicate() in this file, > in logic_imm_decode_wmask(), because that location needs to handle 2 > and 4 bit elements, which dup_const() cannot.) > > Signed-off-by: Peter Maydell > --- > target/arm/translate-a64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~