From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5oXC-00057T-RR for qemu-devel@nongnu.org; Thu, 26 May 2016 02:12:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5oX5-0008Iu-Me for qemu-devel@nongnu.org; Thu, 26 May 2016 02:12:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5oX5-0008Ip-Gb for qemu-devel@nongnu.org; Thu, 26 May 2016 02:12:35 -0400 From: Amit Shah Date: Thu, 26 May 2016 11:41:53 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PULL 02/28] io: avoid double-free when closing QIOChannelBuffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Juan Quintela , "Dr. David Alan Gilbert" , "Daniel P. Berrange" , qemu list , Amit Shah From: "Daniel P. Berrange" The QIOChannelBuffer's close implementation will free the internal data buffer. It failed to reset the pointer to NULL though, so when the object is later finalized it will free it a second time with predictable crash. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange Reviewed-by: Juan Quintela Message-Id: <1461751518-12128-3-git-send-email-berrange@redhat.com> Signed-off-by: Amit Shah --- io/channel-buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/io/channel-buffer.c b/io/channel-buffer.c index 3e5117b..43d7959 100644 --- a/io/channel-buffer.c +++ b/io/channel-buffer.c @@ -140,6 +140,7 @@ static int qio_channel_buffer_close(QIOChannel *ioc, QIOChannelBuffer *bioc = QIO_CHANNEL_BUFFER(ioc); g_free(bioc->data); + bioc->data = NULL; bioc->capacity = bioc->usage = bioc->offset = 0; return 0; -- 2.5.5