From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Yang Zhong" <yang.zhong@intel.com>,
"Paul Burton" <pburton@wavecomp.com>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>,
"James Hogan" <jhogan@kernel.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 6/6] mips: Express dependencies of the Loongson 2E machine with kconfig
Date: Mon, 4 Feb 2019 09:46:30 +0100 [thread overview]
Message-ID: <d6594582-7fea-0c8a-e2a9-7ff90c0c55dc@redhat.com> (raw)
In-Reply-To: <20190203220744.11734-7-philmd@redhat.com>
On 2019-02-03 23:07, Philippe Mathieu-Daudé wrote:
> The Loongson 2E uses a Bonito64 system controller as North Bridge and a
> VT82C686 chipset as South Bridge. The network card chipset is a RTL8139D.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
[...]
> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
> index 2940ff39ab..16b2bdb068 100644
> --- a/hw/mips/Kconfig
> +++ b/hw/mips/Kconfig
> @@ -42,6 +42,11 @@ config JAZZ
>
> config FULONG
> bool
> + select PCI_BONITO
> + select VT82C686
> + select SMBUS_EEPROM
> + select RTL8139_PCI
If I've got the code right, the RTL8139 is optional for this board, i.e.
when you run with -nodefaults or -net none, then the board is still
usable. So this is not a hard requirement and thus I think it would be
nicer to drop the "select RTL8139_PCI" and rely on the "default y if
PCI_DEVICES" in the hw/net/Kconfig file.
Thomas
next prev parent reply other threads:[~2019-02-04 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 22:07 [Qemu-devel] [PATCH 0/6] Kconfig dependencies for MIPS machines (but Malta) Philippe Mathieu-Daudé
2019-02-03 22:07 ` [Qemu-devel] [PATCH 1/6] mips: Express dependencies of the MIPSsim machine with kconfig Philippe Mathieu-Daudé
2019-02-04 8:31 ` Thomas Huth
2019-02-04 8:36 ` Thomas Huth
2019-02-04 11:05 ` Philippe Mathieu-Daudé
2019-02-04 11:21 ` Paolo Bonzini
2019-02-04 11:55 ` Philippe Mathieu-Daudé
2019-02-03 22:07 ` [Qemu-devel] [PATCH 2/6] mips: Express dependencies of the Jazz " Philippe Mathieu-Daudé
2019-02-04 8:36 ` Thomas Huth
2019-02-03 22:07 ` [Qemu-devel] [PATCH 3/6] mips: Express dependencies of the r4k platform " Philippe Mathieu-Daudé
2019-02-04 8:39 ` Thomas Huth
2019-02-03 22:07 ` [Qemu-devel] [PATCH 4/6] mips: Express dependencies of the Boston machine " Philippe Mathieu-Daudé
2019-02-03 22:07 ` [Qemu-devel] [PATCH 5/6] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge Philippe Mathieu-Daudé
2019-02-04 8:40 ` Thomas Huth
2019-02-03 22:07 ` [Qemu-devel] [PATCH 6/6] mips: Express dependencies of the Loongson 2E machine with kconfig Philippe Mathieu-Daudé
2019-02-04 8:46 ` Thomas Huth [this message]
2019-02-04 20:16 ` Philippe Mathieu-Daudé
2019-02-04 0:06 ` [Qemu-devel] [PATCH 0/6] Kconfig dependencies for MIPS machines (but Malta) Philippe Mathieu-Daudé
2019-02-04 9:51 ` Thomas Huth
2019-02-04 11:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6594582-7fea-0c8a-e2a9-7ff90c0c55dc@redhat.com \
--to=thuth@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=hpoussin@reactos.org \
--cc=jhogan@kernel.org \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).