* [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32()
@ 2025-09-25 0:48 Philippe Mathieu-Daudé
2025-10-06 4:12 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-09-25 0:48 UTC (permalink / raw)
To: qemu-devel
Cc: Pierrick Bouvier, Anton Johansson, Stafford Horne,
Philippe Mathieu-Daudé
Both OpenRISCTLBEntry fields are of uint32_t type. Use the
appropriate VMSTATE_UINT32() macro.
There is no functional change (the migration stream is not
modified), because the OpenRISC targets are only built as 32-bit:
$ git grep TARGET_LONG_BITS configs/targets/or1k-*
configs/targets/or1k-linux-user.mak:5:TARGET_LONG_BITS=32
configs/targets/or1k-softmmu.mak:5:TARGET_LONG_BITS=32
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/openrisc/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c
index 081c706d02c..fa054e528bd 100644
--- a/target/openrisc/machine.c
+++ b/target/openrisc/machine.c
@@ -26,8 +26,8 @@ static const VMStateDescription vmstate_tlb_entry = {
.version_id = 1,
.minimum_version_id = 1,
.fields = (const VMStateField[]) {
- VMSTATE_UINTTL(mr, OpenRISCTLBEntry),
- VMSTATE_UINTTL(tr, OpenRISCTLBEntry),
+ VMSTATE_UINT32(mr, OpenRISCTLBEntry),
+ VMSTATE_UINT32(tr, OpenRISCTLBEntry),
VMSTATE_END_OF_LIST()
}
};
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32()
2025-09-25 0:48 [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32() Philippe Mathieu-Daudé
@ 2025-10-06 4:12 ` Philippe Mathieu-Daudé
2025-10-06 11:15 ` Anton Johansson via
2025-10-07 8:22 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-06 4:12 UTC (permalink / raw)
To: qemu-devel
Cc: Pierrick Bouvier, Anton Johansson, Stafford Horne, qemu-trivial
ping
On 25/9/25 02:48, Philippe Mathieu-Daudé wrote:
> Both OpenRISCTLBEntry fields are of uint32_t type. Use the
> appropriate VMSTATE_UINT32() macro.
>
> There is no functional change (the migration stream is not
> modified), because the OpenRISC targets are only built as 32-bit:
>
> $ git grep TARGET_LONG_BITS configs/targets/or1k-*
> configs/targets/or1k-linux-user.mak:5:TARGET_LONG_BITS=32
> configs/targets/or1k-softmmu.mak:5:TARGET_LONG_BITS=32
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/openrisc/machine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c
> index 081c706d02c..fa054e528bd 100644
> --- a/target/openrisc/machine.c
> +++ b/target/openrisc/machine.c
> @@ -26,8 +26,8 @@ static const VMStateDescription vmstate_tlb_entry = {
> .version_id = 1,
> .minimum_version_id = 1,
> .fields = (const VMStateField[]) {
> - VMSTATE_UINTTL(mr, OpenRISCTLBEntry),
> - VMSTATE_UINTTL(tr, OpenRISCTLBEntry),
> + VMSTATE_UINT32(mr, OpenRISCTLBEntry),
> + VMSTATE_UINT32(tr, OpenRISCTLBEntry),
> VMSTATE_END_OF_LIST()
> }
> };
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32()
2025-09-25 0:48 [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32() Philippe Mathieu-Daudé
2025-10-06 4:12 ` Philippe Mathieu-Daudé
@ 2025-10-06 11:15 ` Anton Johansson via
2025-10-07 8:22 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Anton Johansson via @ 2025-10-06 11:15 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, Pierrick Bouvier, Stafford Horne
On 25/09/25, Philippe Mathieu-Daudé wrote:
> Both OpenRISCTLBEntry fields are of uint32_t type. Use the
> appropriate VMSTATE_UINT32() macro.
>
> There is no functional change (the migration stream is not
> modified), because the OpenRISC targets are only built as 32-bit:
>
> $ git grep TARGET_LONG_BITS configs/targets/or1k-*
> configs/targets/or1k-linux-user.mak:5:TARGET_LONG_BITS=32
> configs/targets/or1k-softmmu.mak:5:TARGET_LONG_BITS=32
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/openrisc/machine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c
> index 081c706d02c..fa054e528bd 100644
> --- a/target/openrisc/machine.c
> +++ b/target/openrisc/machine.c
> @@ -26,8 +26,8 @@ static const VMStateDescription vmstate_tlb_entry = {
> .version_id = 1,
> .minimum_version_id = 1,
> .fields = (const VMStateField[]) {
> - VMSTATE_UINTTL(mr, OpenRISCTLBEntry),
> - VMSTATE_UINTTL(tr, OpenRISCTLBEntry),
> + VMSTATE_UINT32(mr, OpenRISCTLBEntry),
> + VMSTATE_UINT32(tr, OpenRISCTLBEntry),
> VMSTATE_END_OF_LIST()
> }
> };
> --
> 2.51.0
>
Reviewed-by: Anton Johansson <anjo@rev.ng>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32()
2025-09-25 0:48 [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32() Philippe Mathieu-Daudé
2025-10-06 4:12 ` Philippe Mathieu-Daudé
2025-10-06 11:15 ` Anton Johansson via
@ 2025-10-07 8:22 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-07 8:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Pierrick Bouvier, Anton Johansson, Stafford Horne
On 25/9/25 02:48, Philippe Mathieu-Daudé wrote:
> Both OpenRISCTLBEntry fields are of uint32_t type. Use the
> appropriate VMSTATE_UINT32() macro.
>
> There is no functional change (the migration stream is not
> modified), because the OpenRISC targets are only built as 32-bit:
>
> $ git grep TARGET_LONG_BITS configs/targets/or1k-*
> configs/targets/or1k-linux-user.mak:5:TARGET_LONG_BITS=32
> configs/targets/or1k-softmmu.mak:5:TARGET_LONG_BITS=32
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/openrisc/machine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-07 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-25 0:48 [PATCH] target/openrisc: Replace VMSTATE_UINTTL() -> VMSTATE_UINT32() Philippe Mathieu-Daudé
2025-10-06 4:12 ` Philippe Mathieu-Daudé
2025-10-06 11:15 ` Anton Johansson via
2025-10-07 8:22 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).