From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eS7le-00039R-Mm for qemu-devel@nongnu.org; Thu, 21 Dec 2017 15:48:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eS7la-0003N3-Py for qemu-devel@nongnu.org; Thu, 21 Dec 2017 15:48:38 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:56925) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eS7la-0003MV-Dj for qemu-devel@nongnu.org; Thu, 21 Dec 2017 15:48:34 -0500 From: Laurent Vivier References: <151388621863.99.14752373861605263949@5adcb62bf0d6> Message-ID: Date: Thu, 21 Dec 2017 21:48:24 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 0/5] M68k for 2.12 patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Le 21/12/2017 à 21:27, Laurent Vivier a écrit : > Le 21/12/2017 à 20:57, no-reply@patchew.org a écrit : >> Hi, >> >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce it >> locally. >> >> Type: series >> Message-id: 20171221193640.27418-1-laurent@vivier.eu >> Subject: [Qemu-devel] [PULL 0/5] M68k for 2.12 patches >> > ... >> Configure options: >> --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install --cross-prefix=x86_64-w64-mingw32- --enable-trace-backends=simple --enable-debug --enable-gnutls --enable-nettle --enable-curl --enable-vnc --enable-bzip2 --enable-guest-agent --with-sdlabi=1.2 --with-gtkabi=2.0 > ... >> /tmp/qemu-test/src/hw/i386/vmport.c: In function 'vmport_ioport_read': >> /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: implicit declaration of function 'qemu_log_mask' [-Werror=implicit-function-declaration] >> qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command); >> ^~~~~~~~~~~~~ >> /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: nested extern declaration of 'qemu_log_mask' [-Werror=nested-externs] >> /tmp/qemu-test/src/hw/i386/vmport.c:81:23: error: 'LOG_UNIMP' undeclared (first use in this function) >> qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command); >> ^~~~~~~~~ >> /tmp/qemu-test/src/hw/i386/vmport.c:81:23: note: each undeclared identifier is reported only once for each function it appears in >> cc1: all warnings being treated as errors >> make[1]: *** [hw/i386/vmport.o] Error 1 >> make[1]: *** Waiting for unfinished jobs.... > > Looks like a patch from Paolo's pull is breaking the build: > > commit 7299e1a411de99761a4260e44b4f1cf2e4e126ef > Author: Philippe Mathieu-Daudé > Date: Fri Dec 15 00:43:55 2017 -0300 > > hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <20171215034356.4449-2-f4bug@amsat.org> > [Replace unknown command tracepoint with LOG_UNIMP, add > generic tracepoint for vmport commands. - Paolo] > Signed-off-by: Paolo Bonzini This is fixed by: diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index 9b8c68806e..116aa09819 100644 --- a/hw/i386/vmport.c +++ b/hw/i386/vmport.c @@ -27,6 +27,7 @@ #include "hw/i386/pc.h" #include "sysemu/hw_accel.h" #include "hw/qdev.h" +#include "qemu/log.h" #include "trace.h" #define VMPORT_CMD_GETVERSION 0x0a Laurent