From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGmZq-0006hg-5k for qemu-devel@nongnu.org; Tue, 13 Dec 2016 07:53:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGmZm-000162-6g for qemu-devel@nongnu.org; Tue, 13 Dec 2016 07:53:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53128) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGmZm-00015w-15 for qemu-devel@nongnu.org; Tue, 13 Dec 2016 07:52:58 -0500 References: <20161212224325.20790-1-marcandre.lureau@redhat.com> <20161212224325.20790-35-marcandre.lureau@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 13 Dec 2016 13:52:54 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 34/54] char: create chardev-obj-y List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org On 13/12/2016 13:40, Marc-Andr=C3=A9 Lureau wrote: >=20 > On 12/12/2016 23:43, Marc-Andr=C3=A9 Lureau wrote: > > This will help to split char.c in several units without having to > > reference them all everywhere. > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > > --- > > Makefile | 3 ++- > > Makefile.objs | 4 +++- > > Makefile.target | 3 +++ > > chardev/Makefile.objs | 2 +- > > tests/Makefile.include | 4 ++-- > > 5 files changed, 11 insertions(+), 5 deletions(-) >=20 > Any reason to do this instead of keeping common-obj-y? >=20 >=20 > common-obj-y has a lot of other units, including vl.o, making it not > possible to link with tests/test-char for ex. However, if we changed it > to link with everything except vl.c (or other changes), we may be able > to link with and test spice-qemu-char. The resulting binaries will > likely explode though. Ok, so it's for tests. Fair enough! Paolo