From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, P J P <ppandit@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>
Cc: "Philippe Mathieu-Daudé" <pmathieu@redhat.com>,
"Arash TC" <tohidi.arash@gmail.com>,
"QEMU Trivial" <qemu-trivial@nongnu.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v1] bt: use size_t type for length parameters instead of int
Date: Tue, 6 Nov 2018 19:56:11 +0100 [thread overview]
Message-ID: <d68a8ce9-7be0-9f10-23a1-eed362ee7f18@redhat.com> (raw)
In-Reply-To: <1055bb12-6b57-1240-790c-930f2405ebee@redhat.com>
On 06/11/2018 15:52, Thomas Huth wrote:
> The bluetooth subsystem is completely unmaintained, so if Paolo does not
> want to pick it up through his "misc" tree, maybe Peter could apply this
> patch directly? Or maybe it could go through the trivial tree since it
> does not look very complicated?
I wanted to check that there were no possible underflows, but that takes
time.
> FWIW, the patch looks OK to me at a first glance, so:
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> PS: I still think we should deprecate the bt subsystem, since nobody
> really touched it within years...
Well, apparently there _are_ people using it, and it worked for them.
Or at least they were using it in 2014. I'm sure that if people
starting poking at it, some holes would appear, but it appears to work
decently.
Paolo
next prev parent reply other threads:[~2018-11-06 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 17:58 [Qemu-devel] [PATCH v1] bt: use size_t type for length parameters instead of int P J P
2018-10-26 19:49 ` P J P
2018-11-02 9:05 ` P J P
2018-11-06 14:52 ` Thomas Huth
2018-11-06 15:26 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2018-11-06 18:56 ` Paolo Bonzini [this message]
2018-11-06 15:09 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-11-19 11:14 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68a8ce9-7be0-9f10-23a1-eed362ee7f18@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmathieu@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=tohidi.arash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).