From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK6X2-0002hg-Qf for qemu-devel@nongnu.org; Tue, 06 Nov 2018 13:56:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK6Wu-0002um-Gy for qemu-devel@nongnu.org; Tue, 06 Nov 2018 13:56:54 -0500 References: <20181021175858.25886-1-ppandit@redhat.com> <1055bb12-6b57-1240-790c-930f2405ebee@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 6 Nov 2018 19:56:11 +0100 MIME-Version: 1.0 In-Reply-To: <1055bb12-6b57-1240-790c-930f2405ebee@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] bt: use size_t type for length parameters instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , P J P , Qemu Developers Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Arash TC , QEMU Trivial , Peter Maydell On 06/11/2018 15:52, Thomas Huth wrote: > The bluetooth subsystem is completely unmaintained, so if Paolo does not > want to pick it up through his "misc" tree, maybe Peter could apply this > patch directly? Or maybe it could go through the trivial tree since it > does not look very complicated? I wanted to check that there were no possible underflows, but that takes time. > FWIW, the patch looks OK to me at a first glance, so: > > Acked-by: Thomas Huth > > PS: I still think we should deprecate the bt subsystem, since nobody > really touched it within years... Well, apparently there _are_ people using it, and it worked for them. Or at least they were using it in 2014. I'm sure that if people starting poking at it, some holes would appear, but it appears to work decently. Paolo