From: Steven Sistare <steven.sistare@oracle.com>
To: Peter Xu <peterx@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH V2] migration: export fewer options
Date: Mon, 11 Mar 2024 13:53:52 -0400 [thread overview]
Message-ID: <d69bc25d-d4bf-4ed3-9411-531473ebf088@oracle.com> (raw)
In-Reply-To: <ZeGIKRoY5_VpJjcJ@x1n>
On 3/1/2024 2:47 AM, Peter Xu wrote:
> On Thu, Feb 29, 2024 at 07:03:36AM +0100, Markus Armbruster wrote:
>> Steven Sistare <steven.sistare@oracle.com> writes:
>>
>>> Just a reminder, after our further discussion in the V1 thread,
>>> this patch is still what I propose, no updates needed.
>>>
>>> Markus, I think Peter is looking for your blessing on the new
>>> file name: include/migration/client-options.h.
>>
>> Not my preference, but no objection.
>
> There's yet one alternative, which is to put these exported option
> functions into misc.h directly. After all that's not so much, and misc.h
> already hold random stuff from elsewhere.
>
> Steve, would you repost this patch (with/without my above comment taken)
> along with your other series with a rebase to migration-next? It doesn't
> apply there. Re the other series: one nitpick comment on the last patch,
> where you may consider splitting the removal of the unused 2 functions into
> a standalone patch. Other than that it looks good to me.
>
> https://gitlab.com/peterx/qemu/-/tree/migration-next
Both are rebased and reposted, thanks - steve
prev parent reply other threads:[~2024-03-11 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 22:16 [PATCH V2] migration: export fewer options Steve Sistare
2024-02-28 16:55 ` Steven Sistare
2024-02-29 6:03 ` Markus Armbruster
2024-03-01 7:47 ` Peter Xu
2024-03-11 17:53 ` Steven Sistare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d69bc25d-d4bf-4ed3-9411-531473ebf088@oracle.com \
--to=steven.sistare@oracle.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).