From: David Hildenbrand <david@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
"Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
Richard Henderson <richard.henderson@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 1/6] system/ramblock: Remove obsolete comment
Date: Mon, 29 Sep 2025 18:13:24 +0200 [thread overview]
Message-ID: <d6a3321c-1492-4c64-9341-8071659220fe@redhat.com> (raw)
In-Reply-To: <20250929154529.72504-2-philmd@linaro.org>
On 29.09.25 17:45, Philippe Mathieu-Daudé wrote:
> This comment was added almost 5 years ago in commit 41aa4e9fd84
> ("ram_addr: Split RAMBlock definition"). Clearly it got ignored:
>
> $ git grep -l system/ramblock.h
> hw/display/virtio-gpu-udmabuf.c
> hw/hyperv/hv-balloon.c
> hw/virtio/vhost-user.c
> migration/dirtyrate.c
> migration/file.c
> migration/multifd-nocomp.c
> migration/multifd-qatzip.c
> migration/multifd-qpl.c
> migration/multifd-uadk.c
> migration/multifd-zero-page.c
> migration/multifd-zlib.c
> migration/multifd-zstd.c
> migration/multifd.c
> migration/postcopy-ram.c
> system/ram-block-attributes.c
> target/i386/kvm/tdx.c
> tests/qtest/fuzz/generic_fuzz.c
>
> At this point it seems saner to just remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-29 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 15:45 [PATCH 0/6] system/ramblock: Sanitize header Philippe Mathieu-Daudé
2025-09-29 15:45 ` [PATCH 1/6] system/ramblock: Remove obsolete comment Philippe Mathieu-Daudé
2025-09-29 16:13 ` David Hildenbrand [this message]
2025-09-29 15:45 ` [PATCH 2/6] system/ramblock: Move ram_block_is_pmem() declaration Philippe Mathieu-Daudé
2025-09-29 16:58 ` Alex Bennée
2025-09-29 15:45 ` [PATCH 3/6] system/ramblock: Move ram_block_discard_*_range() declarations Philippe Mathieu-Daudé
2025-09-29 15:45 ` [PATCH 4/6] system/ramblock: Use ram_addr_t in ram_block_discard_guest_memfd_range Philippe Mathieu-Daudé
2025-10-01 15:59 ` Richard Henderson
2025-09-29 15:45 ` [PATCH 5/6] system/ramblock: Use ram_addr_t in ram_block_discard_range() Philippe Mathieu-Daudé
2025-09-29 15:45 ` [PATCH 6/6] system/ramblock: Move RAMBlock helpers out of "system/ram_addr.h" Philippe Mathieu-Daudé
2025-10-01 16:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a3321c-1492-4c64-9341-8071659220fe@redhat.com \
--to=david@redhat.com \
--cc=farosas@suse.de \
--cc=kvm@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).