From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Daniel Brodsky <dnbrdsky@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
"open list:iSCSI" <qemu-block@nongnu.org>,
Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>, Peter Lieven <pl@kamp.de>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate
Date: Fri, 20 Mar 2020 14:51:57 +0100 [thread overview]
Message-ID: <d6b4cbe4-4cf8-7c27-036f-6e180c45e28b@redhat.com> (raw)
In-Reply-To: <20200320125634.GB3464@work-vm>
On 20/03/20 13:56, Dr. David Alan Gilbert wrote:
>> According to https://wiki.qemu.org/ToDo/LockGuards cases that are trivial (no
>> conditional logic) shouldn't be replaced.
> OK
I don't think that has to be either-or. Trivial lock/unlock sequences
are not the first ones that should be converted, but there's an
advantage in having a single patch that converts all possible uses of a
lock. Trivial sequences certainly do not belong in a bigger patch like
this, as they would make the patch even bigger.
> So for what you've already got there,
>
> For migration:
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
Can you just extract that and queue it yourself (for 5.1 probably)?
Paolo
next prev parent reply other threads:[~2020-03-20 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:04 [PATCH v3 0/2] Replaced locks with lock guard macros dnbrdsky
2020-03-20 12:04 ` [PATCH v3 1/2] lockable: fix __COUNTER__ macro to be referenced properly dnbrdsky
2020-03-20 12:04 ` [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate dnbrdsky
2020-03-20 12:33 ` Dr. David Alan Gilbert
2020-03-20 12:46 ` Daniel Brodsky
2020-03-20 12:56 ` Dr. David Alan Gilbert
2020-03-20 13:51 ` Paolo Bonzini [this message]
2020-03-20 13:55 ` Dr. David Alan Gilbert
2020-03-20 14:02 ` [PATCH v3 0/2] Replaced locks with lock guard macros no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b4cbe4-4cf8-7c27-036f-6e180c45e28b@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dnbrdsky@gmail.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).