From: Paolo Bonzini <pbonzini@redhat.com>
To: Bruce Rogers <brogers@suse.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, philmd@redhat.com
Subject: Re: [PATCH] configure: fix gio_libs reference
Date: Tue, 3 Nov 2020 16:00:16 +0100 [thread overview]
Message-ID: <d6e5490c-5286-1bc7-ca37-8f58e9fe9ecc@redhat.com> (raw)
In-Reply-To: <20201103145121.668865-1-brogers@suse.com>
On 03/11/20 15:51, Bruce Rogers wrote:
> The gio library detection code no longer works, due to a missing $ in
> front of the gio_libs reference. Make the string be $gio_libs.
>
> Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
> work")
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2c3c69f118..bc06aa81e5 100755
> --- a/configure
> +++ b/configure
> @@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
> # with pkg-config --static --libs data for gio-2.0 that is missing
> # -lblkid and will give a link error.
> write_c_skeleton
> - if compile_prog "" "gio_libs" ; then
> + if compile_prog "" "$gio_libs" ; then
> gio=yes
> else
> gio=no
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-11-03 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:51 [PATCH] configure: fix gio_libs reference Bruce Rogers
2020-11-03 15:00 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e5490c-5286-1bc7-ca37-8f58e9fe9ecc@redhat.com \
--to=pbonzini@redhat.com \
--cc=brogers@suse.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).