From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.8 v3 1/3] scripts: Allow block module to not define BlockDriver
Date: Mon, 29 Aug 2016 15:11:20 +0200 [thread overview]
Message-ID: <d6f50a1a-7140-fa5b-1143-19ca2cdba669@redhat.com> (raw)
In-Reply-To: <1471418433-20061-2-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On 17.08.2016 09:20, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> scripts/modules/module_block.py | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
> index db4fb54..7efec00 100644
> --- a/scripts/modules/module_block.py
> +++ b/scripts/modules/module_block.py
> @@ -56,11 +56,6 @@ def process_file(fheader, filename):
> format_name = ""
> protocol_name = ""
>
> - if not found_something:
> - print("No BlockDriver struct found in " + filename + ". \
> - Is this really a module?", file=sys.stderr)
> - sys.exit(1)
found_something is now unused. Do you want to remove it?
Max
> -
> def print_top(fheader):
> fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
> /*
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
next prev parent reply other threads:[~2016-08-29 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 7:20 [Qemu-devel] [PATCH for-2.8 v3 0/3] block: Fix libbz2 library dependency regresssion Fam Zheng
2016-08-17 7:20 ` [Qemu-devel] [PATCH for-2.8 v3 1/3] scripts: Allow block module to not define BlockDriver Fam Zheng
2016-08-29 13:11 ` Max Reitz [this message]
2016-08-17 7:20 ` [Qemu-devel] [PATCH for-2.8 v3 2/3] module: Don't load the same module if requested multiple times Fam Zheng
2016-08-29 13:30 ` Max Reitz
2016-09-05 2:27 ` Fam Zheng
2016-08-17 7:20 ` [Qemu-devel] [PATCH for-2.8 v3 3/3] dmg: Move libbz2 code to dmg-bz2.so Fam Zheng
2016-08-17 8:35 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-08-17 8:43 ` [Qemu-devel] [Qemu-block] [PATCH for-2.8 v3 0/3] block: Fix libbz2 library dependency regresssion Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f50a1a-7140-fa5b-1143-19ca2cdba669@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).