From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beMRV-0003Z8-Hm for qemu-devel@nongnu.org; Mon, 29 Aug 2016 09:17:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beMRU-0000lI-GB for qemu-devel@nongnu.org; Mon, 29 Aug 2016 09:17:37 -0400 References: <1471418433-20061-1-git-send-email-famz@redhat.com> <1471418433-20061-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: Date: Mon, 29 Aug 2016 15:11:20 +0200 MIME-Version: 1.0 In-Reply-To: <1471418433-20061-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IE6E9CBJ6nO88nGkO96MBASEKO1WXAvkc" Subject: Re: [Qemu-devel] [PATCH for-2.8 v3 1/3] scripts: Allow block module to not define BlockDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Stefan Hajnoczi , Kevin Wolf , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IE6E9CBJ6nO88nGkO96MBASEKO1WXAvkc From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Stefan Hajnoczi , Kevin Wolf , qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH for-2.8 v3 1/3] scripts: Allow block module to not define BlockDriver References: <1471418433-20061-1-git-send-email-famz@redhat.com> <1471418433-20061-2-git-send-email-famz@redhat.com> In-Reply-To: <1471418433-20061-2-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.08.2016 09:20, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > scripts/modules/module_block.py | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/scripts/modules/module_block.py b/scripts/modules/module_b= lock.py > index db4fb54..7efec00 100644 > --- a/scripts/modules/module_block.py > +++ b/scripts/modules/module_block.py > @@ -56,11 +56,6 @@ def process_file(fheader, filename): > format_name =3D "" > protocol_name =3D "" > =20 > - if not found_something: > - print("No BlockDriver struct found in " + filename + ". \ > - Is this really a module?", file=3Dsys.stderr) > - sys.exit(1) found_something is now unused. Do you want to remove it? Max > - > def print_top(fheader): > fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */ > /* >=20 --IE6E9CBJ6nO88nGkO96MBASEKO1WXAvkc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXxDR4EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQIty B/9eSTDHZ4gHjH27zdJY4+u6Saer2khVmv3nyZSVjWFKAmnP3LpCXk7Fk+VBDQNK XLqP2E6Gzk8QISQ/MQxD4XsNSRKCndzq+XE23Ou7uSyWSUorm/zrzM35fWddeQDg 34h0cFOHliDQ6SQalf0EOBxrh7P13bVWUQf9EoRLROpFcMBeTvEgLIwdDtnri+q0 WJuN0rNyon+TD5qVy2nJ2Qw6C8hL14bc76TvewPOClR60N/kYjRtXp6H3LsX1HEZ pM1A4mAWJL8ezUU3Y0xlw2Sjkj5RrMTbXNP2P/gfurEsMvqGNIPvuv9kaYty/Ze3 AjVNZbVJMdfHeEpLPLhQwdsX =QTUU -----END PGP SIGNATURE----- --IE6E9CBJ6nO88nGkO96MBASEKO1WXAvkc--