From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5889EC04A6B for ; Mon, 6 May 2019 14:06:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E0382054F for ; Mon, 6 May 2019 14:06:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E0382054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:57029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNeG3-0003J3-5F for qemu-devel@archiver.kernel.org; Mon, 06 May 2019 10:06:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNeF5-0002pb-75 for qemu-devel@nongnu.org; Mon, 06 May 2019 10:05:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hNeEz-0001q0-Pi for qemu-devel@nongnu.org; Mon, 06 May 2019 10:05:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43194) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hNeEz-0001nc-KY; Mon, 06 May 2019 10:05:13 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C7766307C942; Mon, 6 May 2019 14:05:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-124-221.rdu2.redhat.com [10.10.124.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id E85F4100194A; Mon, 6 May 2019 14:04:52 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-trivial@nongnu.org, qemu-devel@nongnu.org References: <20190504133540.19758-1-philmd@redhat.com> <20190504133540.19758-2-philmd@redhat.com> From: Laszlo Ersek Message-ID: Date: Mon, 6 May 2019 16:04:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190504133540.19758-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 06 May 2019 14:05:06 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/04/19 15:35, Philippe Mathieu-Daud=C3=A9 wrote: > In commit 1cab464136b4 we incorrectly described the > EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS > options to the EDK2 build tools, but it only expands > the CFLAGS (not to the CPPFLAGS). > Update the description to be more accurate. >=20 > Reported-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > roms/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/roms/Makefile b/roms/Makefile > index 0ce84a45ad5..f020102c866 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms > $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ > $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) > =20 > -# Build scripts can pass compiler/linker flags to the EDK2 build tools > -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and > +# Build scripts can pass compiler/linker flags to the EDK2 > +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and please 'tr -s " "' in the above. With that: Reviewed-by: Laszlo Ersek Thanks Laszlo > # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. > # > # Example: >=20