* [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix
@ 2019-05-04 13:35 Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Laurent Vivier, Michael Tokarev, Philippe Mathieu-Daudé
Hi,
Two trivial patches waiting Laszlo's series to land.
Since v1:
- rebased
v1:
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01589.html
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01598.html
Philippe Mathieu-Daudé (2):
roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
roms: List and describe the Makefile 'clean' rule
roms/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix
2019-05-04 13:35 [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix Philippe Mathieu-Daudé
@ 2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description Philippe Mathieu-Daudé
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule Philippe Mathieu-Daudé
2 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Philippe Mathieu-Daudé, Michael Tokarev, Laurent Vivier
Hi,
Two trivial patches waiting Laszlo's series to land.
Since v1:
- rebased
v1:
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01589.html
https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01598.html
Philippe Mathieu-Daudé (2):
roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
roms: List and describe the Makefile 'clean' rule
roms/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
2019-05-04 13:35 [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
@ 2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:04 ` Laszlo Ersek
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule Philippe Mathieu-Daudé
2 siblings, 2 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Laurent Vivier, Michael Tokarev, Philippe Mathieu-Daudé
In commit 1cab464136b4 we incorrectly described the
EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
options to the EDK2 build tools, but it only expands
the CFLAGS (not to the CPPFLAGS).
Update the description to be more accurate.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/roms/Makefile b/roms/Makefile
index 0ce84a45ad5..f020102c866 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
$(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
$(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
-# Build scripts can pass compiler/linker flags to the EDK2 build tools
-# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
+# Build scripts can pass compiler/linker flags to the EDK2
+# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
# EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
#
# Example:
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description Philippe Mathieu-Daudé
@ 2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:04 ` Laszlo Ersek
1 sibling, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Philippe Mathieu-Daudé, Michael Tokarev, Laurent Vivier
In commit 1cab464136b4 we incorrectly described the
EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
options to the EDK2 build tools, but it only expands
the CFLAGS (not to the CPPFLAGS).
Update the description to be more accurate.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/roms/Makefile b/roms/Makefile
index 0ce84a45ad5..f020102c866 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
$(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
$(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
-# Build scripts can pass compiler/linker flags to the EDK2 build tools
-# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
+# Build scripts can pass compiler/linker flags to the EDK2
+# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
# EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
#
# Example:
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
@ 2019-05-06 14:04 ` Laszlo Ersek
2019-05-06 14:17 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 9+ messages in thread
From: Laszlo Ersek @ 2019-05-06 14:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: Michael Tokarev, Laurent Vivier
On 05/04/19 15:35, Philippe Mathieu-Daudé wrote:
> In commit 1cab464136b4 we incorrectly described the
> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
> options to the EDK2 build tools, but it only expands
> the CFLAGS (not to the CPPFLAGS).
> Update the description to be more accurate.
>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> roms/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 0ce84a45ad5..f020102c866 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
> $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
> $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
>
> -# Build scripts can pass compiler/linker flags to the EDK2 build tools
> -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
> +# Build scripts can pass compiler/linker flags to the EDK2
> +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
please 'tr -s " "' in the above.
With that:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
> #
> # Example:
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description
2019-05-06 14:04 ` Laszlo Ersek
@ 2019-05-06 14:17 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-06 14:17 UTC (permalink / raw)
To: Laszlo Ersek, qemu-trivial, qemu-devel; +Cc: Michael Tokarev, Laurent Vivier
On 5/6/19 4:04 PM, Laszlo Ersek wrote:
> On 05/04/19 15:35, Philippe Mathieu-Daudé wrote:
>> In commit 1cab464136b4 we incorrectly described the
>> EDK2_BASETOOLS_OPTFLAGS can pass CPPFLAGS and CFLAGS
>> options to the EDK2 build tools, but it only expands
>> the CFLAGS (not to the CPPFLAGS).
>> Update the description to be more accurate.
>>
>> Reported-by: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> roms/Makefile | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/roms/Makefile b/roms/Makefile
>> index 0ce84a45ad5..f020102c866 100644
>> --- a/roms/Makefile
>> +++ b/roms/Makefile
>> @@ -121,8 +121,8 @@ build-efi-roms: build-pxe-roms
>> $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
>> $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))
>>
>> -# Build scripts can pass compiler/linker flags to the EDK2 build tools
>> -# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and
>> +# Build scripts can pass compiler/linker flags to the EDK2
>> +# build tools via the EDK2_BASETOOLS_OPTFLAGS (CFLAGS) and
>
> please 'tr -s " "' in the above.
Sharp eagle eye!
>
> With that:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks :)
>
> Thanks
> Laszlo
>
>> # EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables.
>> #
>> # Example:
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule
2019-05-04 13:35 [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description Philippe Mathieu-Daudé
@ 2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:10 ` Laszlo Ersek
2 siblings, 2 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Laurent Vivier, Michael Tokarev, Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/roms/Makefile b/roms/Makefile
index f020102c866..1a6c2fa76f9 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -62,6 +62,8 @@ default:
@echo " u-boot.e500 -- update u-boot.e500"
@echo " u-boot.sam460 -- update u-boot.sam460"
@echo " efi -- update UEFI (edk2) platform firmware"
+ @echo " clean -- delete the files generated by the previous" \
+ "build targets"
bios: build-seabios-config-seabios-128k build-seabios-config-seabios-256k
cp seabios/builds/seabios-128k/bios.bin ../pc-bios/bios.bin
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule Philippe Mathieu-Daudé
@ 2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:10 ` Laszlo Ersek
1 sibling, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-04 13:35 UTC (permalink / raw)
To: qemu-trivial, Laszlo Ersek, qemu-devel
Cc: Philippe Mathieu-Daudé, Michael Tokarev, Laurent Vivier
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
roms/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/roms/Makefile b/roms/Makefile
index f020102c866..1a6c2fa76f9 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -62,6 +62,8 @@ default:
@echo " u-boot.e500 -- update u-boot.e500"
@echo " u-boot.sam460 -- update u-boot.sam460"
@echo " efi -- update UEFI (edk2) platform firmware"
+ @echo " clean -- delete the files generated by the previous" \
+ "build targets"
bios: build-seabios-config-seabios-128k build-seabios-config-seabios-256k
cp seabios/builds/seabios-128k/bios.bin ../pc-bios/bios.bin
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
@ 2019-05-06 14:10 ` Laszlo Ersek
1 sibling, 0 replies; 9+ messages in thread
From: Laszlo Ersek @ 2019-05-06 14:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: Michael Tokarev, Laurent Vivier
On 05/04/19 15:35, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> roms/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index f020102c866..1a6c2fa76f9 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -62,6 +62,8 @@ default:
> @echo " u-boot.e500 -- update u-boot.e500"
> @echo " u-boot.sam460 -- update u-boot.sam460"
> @echo " efi -- update UEFI (edk2) platform firmware"
> + @echo " clean -- delete the files generated by the previous" \
> + "build targets"
>
> bios: build-seabios-config-seabios-128k build-seabios-config-seabios-256k
> cp seabios/builds/seabios-128k/bios.bin ../pc-bios/bios.bin
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-05-06 14:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-04 13:35 [Qemu-devel] [PATCH v2 0/2] roms: Add 'clean' make rule and EDK2 documentation fix Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 1/2] roms: Correct the EDK2_BASETOOLS_OPTFLAGS variable description Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:04 ` Laszlo Ersek
2019-05-06 14:17 ` Philippe Mathieu-Daudé
2019-05-04 13:35 ` [Qemu-devel] [PATCH v2 2/2] roms: List and describe the Makefile 'clean' rule Philippe Mathieu-Daudé
2019-05-04 13:35 ` Philippe Mathieu-Daudé
2019-05-06 14:10 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).