qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Lirong Yuan <yuanzi@google.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jkz@google.com, riku.voipio@iki.fi,
	scw@google.com
Subject: Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64
Date: Fri, 13 Mar 2020 22:45:50 +0100	[thread overview]
Message-ID: <d7185952-521e-8ad5-30fb-cea86e356e5e@vivier.eu> (raw)
In-Reply-To: <20200313002813.3857-1-yuanzi@google.com>

Le 13/03/2020 à 01:28, Lirong Yuan a écrit :
> This change updates TASK_UNMAPPED_BASE (the base address for guest programs) for aarch64. It is needed to allow qemu to work with Thread Sanitizer (TSan), which has specific boundary definitions for memory mappings on different platforms:
> https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/rtl/tsan_platform.h
> 
> Signed-off-by: Lirong Yuan <yuanzi@google.com>
> ---
>  linux-user/mmap.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 8685f02e7e..e378033797 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -184,7 +184,11 @@ static int mmap_frag(abi_ulong real_start,
>  }
>  
>  #if HOST_LONG_BITS == 64 && TARGET_ABI_BITS == 64
> +#ifdef TARGET_AARCH64
> +# define TASK_UNMAPPED_BASE  0x5500000000
> +#else
>  # define TASK_UNMAPPED_BASE  (1ul << 38)
> +#endif
>  #else
>  # define TASK_UNMAPPED_BASE  0x40000000
>  #endif
> 

Applied to my linux-user branch.

Thanks,
Laurent


  parent reply	other threads:[~2020-03-13 21:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  0:28 [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64 Lirong Yuan
2020-03-13 21:44 ` Laurent Vivier
2020-03-13 21:45 ` Laurent Vivier [this message]
2020-03-13 23:52   ` Lirong Yuan
2020-03-14  3:06 ` Aleksandar Markovic
2020-03-14 10:45   ` Laurent Vivier
2020-03-14 17:01     ` Aleksandar Markovic
2020-03-14 17:34       ` Laurent Vivier
2020-03-16 21:50         ` Lirong Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7185952-521e-8ad5-30fb-cea86e356e5e@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jkz@google.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=scw@google.com \
    --cc=yuanzi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).