From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A4CC432C1 for ; Tue, 24 Sep 2019 15:29:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB6C1214DA for ; Tue, 24 Sep 2019 15:29:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB6C1214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCmkU-0005ma-6f for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 11:29:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41524) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iClyc-000056-FZ for qemu-devel@nongnu.org; Tue, 24 Sep 2019 10:39:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iClya-0006Wm-Cc for qemu-devel@nongnu.org; Tue, 24 Sep 2019 10:39:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iClya-0006V7-3h for qemu-devel@nongnu.org; Tue, 24 Sep 2019 10:39:36 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5DC8A30043E1; Tue, 24 Sep 2019 14:39:35 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4FB64503; Tue, 24 Sep 2019 14:39:32 +0000 (UTC) Subject: Re: [PATCH 01/25] qapi: Tighten QAPISchemaFOO.check() assertions To: Markus Armbruster , qemu-devel@nongnu.org References: <20190924132830.15835-1-armbru@redhat.com> <20190924132830.15835-2-armbru@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: Date: Tue, 24 Sep 2019 09:39:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924132830.15835-2-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vRUGrVcOAcwi1rNjSk5gDDN1AQJ8ItlG4" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 24 Sep 2019 14:39:35 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vRUGrVcOAcwi1rNjSk5gDDN1AQJ8ItlG4 Content-Type: multipart/mixed; boundary="VcKfzK3hybY64pGZyobMFdXzoyks88FU4"; protected-headers="v1" From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, marcandre.lureau@redhat.com Message-ID: Subject: Re: [PATCH 01/25] qapi: Tighten QAPISchemaFOO.check() assertions References: <20190924132830.15835-1-armbru@redhat.com> <20190924132830.15835-2-armbru@redhat.com> In-Reply-To: <20190924132830.15835-2-armbru@redhat.com> --VcKfzK3hybY64pGZyobMFdXzoyks88FU4 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/24/19 8:28 AM, Markus Armbruster wrote: > When we introduced the QAPISchema intermediate representation (commit > ac88219a6c7), we took a shortcut: we left check_exprs() & friends > alone instead of moving semantic checks into the > QAPISchemaFOO.check(). check_exprs() still checks and reports errors, > and the .check() assert check_exprs() did the job. There are a few > gaps, though. >=20 > QAPISchemaArrayType.check() neglects to assert the element type is not > an array. Add the assertion. >=20 > QAPISchemaObjectTypeVariants.check() neglects to assert the tag member > is not optional. Add the assertion. >=20 > It neglects to assert the tag member is not conditional. Add the > assertion. >=20 > It neglects to assert we actually have variants. Add the assertion. >=20 > It asserts the variants are object types, but neglects to assert they > don't have variants. Tighten the assertion. >=20 > QAPISchemaObjectTypeVariants.check_clash() has the same issue. > However, it can run only after .check(). Delete the assertion instead > of tightening it. >=20 > QAPISchemaAlternateType.check() neglects to assert the branch types > don't conflict. Fixing that isn't trivial, so add just a TODO comment > for now. It'll be resolved later in this series. I'm guessing you found these by deleting check_exprs() and seeing what failed due to inadequate .check() >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi/common.py | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --VcKfzK3hybY64pGZyobMFdXzoyks88FU4-- --vRUGrVcOAcwi1rNjSk5gDDN1AQJ8ItlG4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl2KKqMACgkQp6FrSiUn Q2oelAf+OVFZA3aCE+6T+4PEeAQNcfTeTzQaZZD/dURBk8fdIg7d0ba03QYi9hTP KcWZn41EMzXFi7E4ylb8zjqB3bPoCw7XLZ13F3nmp+cWMN0rMCivB6wLclCZ7Nwc m/wxcOJIVMe8RL6qO+ZlOM8OslIbyNdwEvcH6Sepswf2BzZi0scfxrNwHutO/vd/ vkcK6lMf6Tr242QnaNpOXgdNLt36EMcrSgsBUu71cf0GgCBZcLUj1iZRi6WZQRMU UEt62pWJi9CPy8gDBHV7JE21DRmahfoiOdNizICEAkc6eQhs0ABM0ZOWU1DZ8d5T K5AIMfFUer+LvNHsKcPWMoz9ODYx9A== =Evxl -----END PGP SIGNATURE----- --vRUGrVcOAcwi1rNjSk5gDDN1AQJ8ItlG4--