From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
Markus Armbruster <armbru@redhat.com>,
qemu-ppc@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99
Date: Wed, 9 Jan 2019 22:20:13 +0100 [thread overview]
Message-ID: <d72673fa-52a5-a6ff-6aa8-34f2b4b6855f@redhat.com> (raw)
In-Reply-To: <20190109172801.GB3998@redhat.com>
On 09/01/19 18:28, Daniel P. Berrangé wrote:
>> so both files include each other, how nice ...
> If the header files are mutually dependent it makes me wonder what the
> point of having them split up is ?
>
> Feels like either they need to be merged, or they need to be split up
> and refactored even more to remove the mutual dependancy.
If they include each other only for the typedefs, then prehaps the
solution is to change the coding style and allow using struct in
function prototypes. I'm pretty sure there are several examples of this
already.
Paolo
next prev parent reply other threads:[~2019-01-09 21:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 16:39 [Qemu-devel] [PATCH v3 0/2] Force the C standard to gnu99 Thomas Huth
2019-01-09 16:39 ` [Qemu-devel] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99 Thomas Huth
2019-01-09 17:13 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2019-01-09 17:28 ` Daniel P. Berrangé
2019-01-09 17:40 ` Cédric Le Goater
2019-01-09 17:47 ` Greg Kurz
2019-01-10 6:47 ` Thomas Huth
2019-01-09 21:20 ` Paolo Bonzini [this message]
2019-01-09 21:25 ` Eric Blake
2019-01-09 21:31 ` Paolo Bonzini
2019-01-10 10:12 ` Daniel P. Berrangé
2019-01-10 12:12 ` Greg Kurz
2019-01-10 6:46 ` Thomas Huth
2019-01-09 17:46 ` Cédric Le Goater
2019-01-09 16:39 ` [Qemu-devel] [PATCH v3 2/2] configure: Force the C standard to gnu99 Thomas Huth
2019-01-09 18:10 ` Philippe Mathieu-Daudé
2019-01-09 21:26 ` Paolo Bonzini
2019-01-10 6:50 ` Thomas Huth
2019-01-09 21:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d72673fa-52a5-a6ff-6aa8-34f2b4b6855f@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).