From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghLGz-0002pU-Ur for qemu-devel@nongnu.org; Wed, 09 Jan 2019 16:20:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghLGx-000676-UZ for qemu-devel@nongnu.org; Wed, 09 Jan 2019 16:20:25 -0500 References: <1547051976-13982-1-git-send-email-thuth@redhat.com> <1547051976-13982-2-git-send-email-thuth@redhat.com> <3316bf08-36c0-c3ce-4e4f-8244276c58d3@kaod.org> <20190109172801.GB3998@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 9 Jan 2019 22:20:13 +0100 MIME-Version: 1.0 In-Reply-To: <20190109172801.GB3998@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: Thomas Huth , qemu-devel@nongnu.org, peter.maydell@linaro.org, Markus Armbruster , qemu-ppc@nongnu.org, Richard Henderson On 09/01/19 18:28, Daniel P. Berrang=C3=A9 wrote: >> so both files include each other, how nice ... > If the header files are mutually dependent it makes me wonder what the > point of having them split up is ? >=20 > Feels like either they need to be merged, or they need to be split up > and refactored even more to remove the mutual dependancy. If they include each other only for the typedefs, then prehaps the solution is to change the coding style and allow using struct in function prototypes. I'm pretty sure there are several examples of this already. Paolo