From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Richard W . M . Jones" <rjones@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] vl: remove unnecessary #ifdef CONFIG_TPM
Date: Mon, 23 Oct 2017 17:47:23 -0400 [thread overview]
Message-ID: <d72adc87-3cc6-a6cd-8fc8-50ba8e0fbe88@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171023213359.23025-4-f4bug@amsat.org>
On 10/23/2017 05:33 PM, Philippe Mathieu-Daudé wrote:
> a stub is now provided.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> vl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 0723835bbf..ec299099ff 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4624,11 +4624,9 @@ int main(int argc, char **argv, char **envp)
> exit(1);
> }
>
> -#ifdef CONFIG_TPM
> if (tpm_init() < 0) {
> exit(1);
> }
> -#endif
>
> /* init the bluetooth world */
> if (foreach_device_config(DEV_BT, bt_parse))
Now you should be able to also remove the #ifdef CONFIG_TPM from ./tpm.c.
Stefan
prev parent reply other threads:[~2017-10-23 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 21:33 [Qemu-devel] [PATCH 0/3] tpm: add stubs to fix compiling with --disable-tpm Philippe Mathieu-Daudé
2017-10-23 21:33 ` [Qemu-devel] [PATCH 1/3] tpm: add missing include Philippe Mathieu-Daudé
2017-10-23 21:33 ` [Qemu-devel] [PATCH 2/3] tpm: add stubs Philippe Mathieu-Daudé
2017-10-23 21:33 ` [Qemu-devel] [PATCH 3/3] vl: remove unnecessary #ifdef CONFIG_TPM Philippe Mathieu-Daudé
2017-10-23 21:37 ` Richard W.M. Jones
2017-10-24 2:33 ` Philippe Mathieu-Daudé
2017-10-24 7:29 ` Richard W.M. Jones
2017-10-23 21:47 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d72adc87-3cc6-a6cd-8fc8-50ba8e0fbe88@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=balaton@eik.bme.hu \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).