From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v8 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
Date: Mon, 15 Jun 2020 07:43:19 +0200 [thread overview]
Message-ID: <d737209f-bb8e-ada2-f899-8b26ad9f7df2@redhat.com> (raw)
In-Reply-To: <20200609170727.9977-2-philmd@redhat.com>
On 06/09/20 19:07, Philippe Mathieu-Daudé wrote:
> The FW_CFG_DATA_GENERATOR allows any object to produce
> blob of data consumable by the fw_cfg device.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v8: addressed Laszlo's comments
> - fixed copy/paste typos
> - corrected fmt arguments order
> - do not call fw_cfg_add_file() if get_length() returned 0
> ---
> docs/specs/fw_cfg.txt | 9 ++++++-
> include/hw/nvram/fw_cfg.h | 52 +++++++++++++++++++++++++++++++++++++++
> hw/nvram/fw_cfg.c | 36 +++++++++++++++++++++++++++
> 3 files changed, 96 insertions(+), 1 deletion(-)
looks good, thanks!
next prev parent reply other threads:[~2020-06-15 5:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 17:07 [PATCH v8 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites Philippe Mathieu-Daudé
2020-06-09 17:07 ` [PATCH v8 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface Philippe Mathieu-Daudé
2020-06-15 5:43 ` Laszlo Ersek [this message]
2020-06-09 17:07 ` [PATCH v8 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument Philippe Mathieu-Daudé
2020-06-15 5:47 ` Laszlo Ersek
2020-06-09 17:07 ` [PATCH v8 3/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace Philippe Mathieu-Daudé
2020-06-15 5:52 ` Laszlo Ersek
2020-06-09 17:07 ` [PATCH v8 4/5] crypto: Add tls-cipher-suites object Philippe Mathieu-Daudé
2020-06-15 6:10 ` Laszlo Ersek
2020-06-09 17:07 ` [PATCH v8 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob Philippe Mathieu-Daudé
2020-06-09 17:10 ` Philippe Mathieu-Daudé
2020-06-15 6:16 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d737209f-bb8e-ada2-f899-8b26ad9f7df2@redhat.com \
--to=lersek@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).