qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Lucas Dietrich <ld.adecy@gmail.com>
Cc: qemu-devel@nongnu.org, mrolnik@gmail.com, qemu-trivial@nongnu.org
Subject: Re: [PATCH] Fix handling of AVR interrupts above 33.
Date: Wed, 14 Jun 2023 14:22:14 +0200	[thread overview]
Message-ID: <d7404559-407e-5742-666c-6330da3d3e2c@linaro.org> (raw)
In-Reply-To: <20230614140748.3584-1-ld.adecy@gmail.com>

On 14/6/23 16:07, Lucas Dietrich wrote:
> This commit addresses a bug in the AVR interrupt handling code.
> The modification involves replacing the usage of the ctz32 function
> with ctz64 to ensure proper handling of interrupts above 33 in the AVR
> target.
> 
> Previously, timers 3, 4, and 5 interrupts were not functioning correctly
> because most of their interrupt vectors are numbered above 33.
> 
> Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com>
> ---
>   target/avr/helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for insisting with the patch posting process :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-06-14 12:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 14:07 [PATCH] Fix handling of AVR interrupts above 33 Lucas Dietrich
2023-06-14 12:22 ` Philippe Mathieu-Daudé [this message]
2023-06-14 12:29   ` Michael Rolnik
2023-06-18  6:56 ` Michael Tokarev
2023-06-18 10:27   ` Philippe Mathieu-Daudé
  -- strict thread matches above, loose matches on Subject: below --
2023-06-13 19:34 Lucas Dietrich
2023-06-14  4:32 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7404559-407e-5742-666c-6330da3d3e2c@linaro.org \
    --to=philmd@linaro.org \
    --cc=ld.adecy@gmail.com \
    --cc=mrolnik@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).