From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 698FDCA9EAF for ; Mon, 21 Oct 2019 16:50:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32D1D2086D for ; Mon, 21 Oct 2019 16:50:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oxKc1+ak" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32D1D2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMatC-0007so-DX for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 12:50:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40281) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMasN-00075o-RD for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:49:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMasM-0007XP-Tt for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:49:47 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:34778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMasM-0007X7-OJ for qemu-devel@nongnu.org; Mon, 21 Oct 2019 12:49:46 -0400 Received: by mail-pf1-x443.google.com with SMTP id b128so8795731pfa.1 for ; Mon, 21 Oct 2019 09:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/iRyJKfvIZUCUKpEt4I8a3yw43BHIcxJnELB9yQR39M=; b=oxKc1+akw1KDrlwFJFHgCf1+1i/B2yFJSzpb1ARrBHT/aV3CvM+Rnieac1UEqhFZUS 3CP87tUz/4tPg4J72Ccavzh5FLe80OB8gfyTt4zZAUgFSRd5emq7S/VV/pbyCoQMXKBV 3jz+YMIKPB3BoGN2mQ9a8TprK6dmqTzkNTinacJm9yjazmbV4u30v5qlNYd9onicPgGj 0A8RJp5PsmcMKlvaBRFmd9HmFz6mS27/WnaRkcciD1QzL4zNU+4Flfjuk04GehuaD82g OuO/8mDuGQqxk1qFiMc8RICBdkx19UKUniG+nhoWnkxN+KO7fLWdSG1zTcvjxIz4LkRw +HEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/iRyJKfvIZUCUKpEt4I8a3yw43BHIcxJnELB9yQR39M=; b=Nw2Mlxvk2ox11WC6BAMBdy5gwpFIOK/T/YA+rYkQ4hUSm43wOVu8l/PrHqF44cq6Cx Wz+x4k1992q2D6r/qpR2d1irS1EgU0Oj6t4WIOIipStS3zTglXVdHeKUSDX4gNymUq/V 1hRne4MLly57XRpic2FzsnXbjIqPtJH0DkphwpE1wZxbBLefwvUoIN/MEGGPO3uHAC5R rGwFOo6fxxaceHIQ9qBbzZ032KaZTex9M8QjbogmfyGk0QdyRDR2KdWC9bmGKd1TRW6h XcUahpxVIWamrd2K3+EAtX0DmcgRBcQWSx8DrDAli7vVl1fifnLDZaP2Fai/ZHygW6lW wg6w== X-Gm-Message-State: APjAAAWzH+KbCDVBkmHR45POCvdi5Ik40TdmDJ8E4ngzIPLJUzEsX2IS Y3GnJN4+xkqaTaXKszHriPpzEA== X-Google-Smtp-Source: APXvYqxG+v1IaMBDQOaEZdBEHM1/x8UGoMX24W/nMgWS77OYSpVJTK7njtFFar0oJ8fchhpr1Dtg+Q== X-Received: by 2002:aa7:8ad0:: with SMTP id b16mr24564153pfd.255.1571676585557; Mon, 21 Oct 2019 09:49:45 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id k23sm15205671pgi.49.2019.10.21.09.49.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Oct 2019 09:49:44 -0700 (PDT) Subject: Re: [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Markus Armbruster , Eduardo Habkost References: <20191020225650.3671-1-philmd@redhat.com> <20191020225650.3671-2-philmd@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 21 Oct 2019 09:49:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191020225650.3671-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , "Michael S. Tsirkin" , Leif Lindholm , Andrew Jeffery , Mark Cave-Ayland , KONRAD Frederic , "Edgar E. Iglesias" , Rob Herring , Peter Maydell , Helge Deller , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Antony Pavlov , Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Joel Stanley , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Richard Henderson , Radoslaw Biernacki , Thomas Huth , Andrew Baumann , Jean-Christophe Dubois , Andrey Smirnov , Michael Walle , qemu-ppc@nongnu.org, Aleksandar Markovic , Jan Kiszka , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/xilinx_zynq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~