From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17DBDC25B7E for ; Tue, 4 Jun 2024 08:09:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEPDd-0003Bk-De; Tue, 04 Jun 2024 04:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEPDb-0003A6-GM for qemu-devel@nongnu.org; Tue, 04 Jun 2024 04:08:31 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEPDZ-00007o-QD for qemu-devel@nongnu.org; Tue, 04 Jun 2024 04:08:31 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-421124a0b37so34728415e9.1 for ; Tue, 04 Jun 2024 01:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717488508; x=1718093308; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ytNDWVR2oHjQ3nd9kyIjG9dFmCbjdL9BJfVV+A4Cikc=; b=lXNlfLAWxaPAD+qFFLma+UM0B+BxF+vukHkvLERbklr20AC0C9ZQi1dKkOmgWLXunE CY38oSO5gnnc9apCqktc/Sxa9gU+pmvOZ48fQ+GTpDkvTIuRu1CaaldDGfXiLSiRDPCH Ac3k58ioVA2WmUaJeoNVlkN83AJw6SMMCNieMjgXUp+bGCZaTIWQ23q5/WAuy/XbQoV6 WNGSgdMuTb5kOpNBMhU4EON2RUUzgk+hI4DoZIByVh2mhBpHhPf6Y067r+lim+dyf7AB J71AXc9qbK4svRoWOKB2sKlCNVwI43WrUwc4hf+sbD0sf8NVD+K+8KpEbVawzmIuFk9O TAwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717488508; x=1718093308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ytNDWVR2oHjQ3nd9kyIjG9dFmCbjdL9BJfVV+A4Cikc=; b=AmJEWhA/J/ZOSiabBuxzeCDVAXmoybJWmIu/eUpHhtdry7qxg2In+CrmE+salX83UZ XP5HKnvkJOMtOaXhLr347XcSj2G7+xbpSrCE8UdhlaLUaOQzkSATfU/ovxhSkbTyGchy AqwWwTo0R0o3oDAdY1NVqvQS6D5xuEKrQYvwQKjD6dnBpju1baQXfN70GBzNTXeAb32Y rrRWevN9NQpdNSCtjQ5xEyPRofWCAvWSH+Fy3EsGKOIio0g7NbMlqGBD0rg9LcjdpdLx MMEtnBHQJRatlJShVxeRnaP8U3W66X+5BIbD4TKHzJNLTGdtEWW/uHKlguQvD2jvnJ1m KVzw== X-Gm-Message-State: AOJu0YyICHbJ7DWHElxn3LsW0hjBsaHDn22cUlg/kr8dqu6vUWdoRaMV MgJkt62jy8xqkCX1NRISlJJ9WbLlJQlMfWEhoDkMs2ztmsqUeSQy5BihbGIs2OAM6A/SSnWq82w x X-Google-Smtp-Source: AGHT+IHf8Ie12xc3+rg0kBy0ZVzg1wR5OGDQWUC9sW2OKDYcfQjfBrdubAMeqDqyFFFA7PxKhuXBHg== X-Received: by 2002:a05:600c:4f06:b0:421:28e6:990b with SMTP id 5b1f17b1804b1-4212e0addf8mr98161125e9.25.1717488507855; Tue, 04 Jun 2024 01:08:27 -0700 (PDT) Received: from [192.168.69.100] ([176.176.159.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4212b8a4cb3sm145568275e9.35.2024.06.04.01.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 01:08:27 -0700 (PDT) Message-ID: Date: Tue, 4 Jun 2024 10:08:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] target/riscv: Use get_address() to get address with Zicbom extensions To: Alistair Francis Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Palmer Dabbelt , Bin Meng , Alistair Francis , Christoph Muellner , Philipp Tomsich , Liu Zhiwei , Weiwei Li , Palmer Dabbelt , Daniel Henrique Barboza , Zhiwei Jiang References: <20240419110514.69697-1-philmd@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/6/24 02:20, Alistair Francis wrote: > On Wed, May 29, 2024 at 2:56 PM Philippe Mathieu-Daudé > wrote: >> >> ping? > > I originally missed this patch somehow and it has then been fixed > separately as part of > https://patchew.org/QEMU/20240514023910.301766-1-alistair.francis@wdc.com/ I see (I also missed your one myself). Maybe add the Fixes/Reported-by tags in yours? > > Alistair > >> >> On 19/4/24 13:05, Philippe Mathieu-Daudé wrote: >>> We need to use get_address() to get an address from cpu_gpr[], >>> since $zero is "special" (NULL). >>> >>> Fixes: e05da09b7c ("target/riscv: implement Zicbom extension") >>> Reported-by: Zhiwei Jiang (姜智伟) >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> target/riscv/insn_trans/trans_rvzicbo.c.inc | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-)