From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
berrange@redhat.com, Thomas Huth <thuth@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose
Date: Thu, 8 Oct 2020 15:52:08 +0200 [thread overview]
Message-ID: <d7603332-3bad-6fd1-0140-79bdec9fa4f1@redhat.com> (raw)
In-Reply-To: <2996442.YqjEYQNFnd@silver>
On 08/10/20 15:42, Christian Schoenebeck wrote:
>>
>> I'm okay I guess with using g_test_message on 2.62 or newer, and
>> assuming people don't use --tap --verbose on older versions.
> Simpler solution: just appending '#' character in front of each printf() line,
> that would be both fine for TAP and regular output:
> http://testanything.org/tap-specification.html#diagnostics
I'm not sure how it would be simpler than a
#if !GLIB_CHECK_VERSION(2, 62, 0)
#define qemu_test_message printf
#else
#define qemu_test_message g_test_message
#endif
but you choose.
Paolo
next prev parent reply other threads:[~2020-10-08 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:15 [PATCH v3 00/11] 9pfs: add tests using local fs driver Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 08/11] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose Christian Schoenebeck
2020-10-08 12:37 ` Paolo Bonzini
2020-10-08 13:09 ` Christian Schoenebeck
2020-10-08 13:21 ` Paolo Bonzini
2020-10-08 13:42 ` Christian Schoenebeck
2020-10-08 13:52 ` Paolo Bonzini [this message]
2020-10-08 15:38 ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 10/11] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 03/11] libqos/qgraph: add qos_dump_graph() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose Christian Schoenebeck
2020-10-08 12:36 ` Paolo Bonzini
2020-10-08 13:11 ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 11/11] tests/9pfs: add local Tmkdir test Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 09/11] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-08 12:26 ` Christian Schoenebeck
2020-10-08 15:34 ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 02/11] libqos/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 07/11] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 04/11] tests/qtest/qos-test: dump qos graph if verbose Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 01/11] libqos/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7603332-3bad-6fd1-0140-79bdec9fa4f1@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).