qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules
Date: Tue, 29 Nov 2016 17:57:04 +0100	[thread overview]
Message-ID: <d765b92b-62fd-d042-ae58-ba3eff4a8a7e@redhat.com> (raw)
In-Reply-To: <20161129162229.GA26498@stefanha-x1.localdomain>



On 29/11/2016 17:22, Stefan Hajnoczi wrote:
> On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote:
>> Building qemu fails in distributions where gcc enables PIE by default
>> (e.g. Debian unstable) with:
>>
>> /usr/bin/ld: -r and -pie may not be used together
>>
>> You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the linker
>> when PIE is enabled and a relocatable object is passed.  However, clang
>> does not know about -r, so try -Wl,-r first.
>>
>> Reported-by: Adrian Bunk <bunk@stusta.de>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  configure | 10 ++++++++--
>>  rules.mak |  2 +-
>>  2 files changed, 9 insertions(+), 3 deletions(-)
> 
> Thanks, applied to my staging tree:
> https://github.com/stefanha/qemu/commits/staging

Okay, then I'll send my pull request without this one.

Paolo

  reply	other threads:[~2016-11-29 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 15:37 [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules Paolo Bonzini
2016-11-29 16:22 ` Stefan Hajnoczi
2016-11-29 16:57   ` Paolo Bonzini [this message]
2016-11-29 17:16     ` Stefan Hajnoczi
2016-11-29 17:43       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d765b92b-62fd-d042-ae58-ba3eff4a8a7e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).