From: BALATON Zoltan <balaton@eik.bme.hu>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>
Cc: npiggin@gmail.com, qemu-ppc@nongnu.org, danielhb413@gmail.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 3/6] target/ppc: optimize hreg_compute_pmu_hflags_value
Date: Mon, 20 May 2024 13:28:15 +0200 (CEST) [thread overview]
Message-ID: <d77225d4-1139-e65a-ddcf-a07fbf9d0ff7@eik.bme.hu> (raw)
In-Reply-To: <20240520103329.381158-4-harshpb@linux.ibm.com>
On Mon, 20 May 2024, Harsh Prateek Bora wrote:
> The second if-condition can be true only if the first one above is true.
> Enclose the latter into the former to avoid un-necessary check if first
> condition fails.
>
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> target/ppc/helper_regs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c
> index 5de0df5795..89aacdf212 100644
> --- a/target/ppc/helper_regs.c
> +++ b/target/ppc/helper_regs.c
> @@ -66,9 +66,9 @@ static uint32_t hreg_compute_pmu_hflags_value(CPUPPCState *env)
> #ifndef CONFIG_USER_ONLY
> if (env->pmc_ins_cnt) {
> hflags |= 1 << HFLAGS_INSN_CNT;
> - }
> - if (env->pmc_ins_cnt & 0x1e) {
> - hflags |= 1 << HFLAGS_PMC_OTHER;
> + if (env->pmc_ins_cnt & 0x1e) {
> + hflags |= 1 << HFLAGS_PMC_OTHER;
> + }
> }
> #endif
> #endif
>
next prev parent reply other threads:[~2024-05-20 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 10:33 [PATCH 0/6] target/ppc: misc ppc improvements/optimizations Harsh Prateek Bora
2024-05-20 10:33 ` [PATCH 1/6] target/ppc: use locally stored msr and avoid indirect access Harsh Prateek Bora
2024-05-20 10:33 ` [PATCH 2/6] target/ppc: optimize hreg_compute_pmu_hflags_value Harsh Prateek Bora
2024-05-20 11:26 ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 3/6] " Harsh Prateek Bora
2024-05-20 11:28 ` BALATON Zoltan [this message]
2024-05-20 10:33 ` [PATCH 4/6] target/ppc: optimize p9 exception handling routines Harsh Prateek Bora
2024-05-20 11:35 ` BALATON Zoltan
2024-05-20 11:36 ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 5/6] target/ppc: reduce duplicate code between init_proc_POWER{9, 10} Harsh Prateek Bora
2024-05-20 11:41 ` BALATON Zoltan
2024-05-20 10:33 ` [PATCH 6/6] target/ppc: redue code duplication across Power9/10 init code Harsh Prateek Bora
2024-05-20 11:52 ` BALATON Zoltan
2024-05-23 5:16 ` Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77225d4-1139-e65a-ddcf-a07fbf9d0ff7@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=danielhb413@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).