From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C761C433B4 for ; Tue, 18 May 2021 21:08:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF75C611BF for ; Tue, 18 May 2021 21:08:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF75C611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj6wd-000720-0x for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 17:08:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj6vv-0006NA-PM for qemu-devel@nongnu.org; Tue, 18 May 2021 17:07:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj6vs-0007NA-NY for qemu-devel@nongnu.org; Tue, 18 May 2021 17:07:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621372035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BLA6Hja+mhTYODa6219j87wvmzkAKulvBU/5xW1FFHI=; b=NlbQbBQ1i0ihICF/PpSFIybAtD54h6q1eqmCN20OQnJ+WxJlzsC79HhA11KdydT4s1EHjN PKtr0tAktsXGVigEJgTUz4b6yJ7sZbOYXQ7O0LsyCnvChSvb7GyUQtgYZTgN4cM0bnElBl f9EZasAz1jthyfb5ipkIZmHZnpPd8ec= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-DPDB_do3OPGklfegy__aMA-1; Tue, 18 May 2021 17:07:12 -0400 X-MC-Unique: DPDB_do3OPGklfegy__aMA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BEA1D107ACCD; Tue, 18 May 2021 21:07:10 +0000 (UTC) Received: from [10.10.117.64] (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED9DC5C1A1; Tue, 18 May 2021 21:07:09 +0000 (UTC) Subject: Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine To: Thomas Huth , Stefan Hajnoczi References: <20210416125256.2039734-1-thuth@redhat.com> <1fea2e39-c1c7-215f-843e-fc593ff7f47c@redhat.com> From: John Snow Message-ID: Date: Tue, 18 May 2021 17:07:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1fea2e39-c1c7-215f-843e-fc593ff7f47c@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John G Johnson , Jagannathan Raman , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/28/21 5:32 AM, Thomas Huth wrote: > On 28/04/2021 11.24, Stefan Hajnoczi wrote: >> On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote: >>> @@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev, >>> Error **errp) >>>       vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d); >>> -    pci_piix_init_ports(d); >>> +    rc = pci_piix_init_ports(d); >>> +    if (rc) { >>> +        error_setg_errno(errp, -rc, "Failed to realize %s", >>> +                         object_get_typename(OBJECT(dev))); >>> +    } >> >> Is there an error message explaining the reason for the failure >> somewhere. I can't see one in the patch and imagine users will be >> puzzled/frustrated by a generic "Failed to realize" error message. Can >> you make it more meaningful? > > Do you have a suggestion for a better message? > >  Thomas > Hi Thomas. Looks like there's some more discussion, and Philippe has a counter-proposal he wants to send. I guess I'll de-queue this for now, and I'll see you on the review for Philippe's series? --js