qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	Dongjiu Geng <gengdongjiu1@gmail.com>,
	Swetha <swjoshi@microsoft.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 3/3] target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors
Date: Thu, 3 Jun 2021 11:56:10 -0700	[thread overview]
Message-ID: <d77a000b-17dd-8c24-360b-ef40a8bb6b9b@linaro.org> (raw)
In-Reply-To: <20210603171259.27962-4-peter.maydell@linaro.org>

On 6/3/21 10:12 AM, Peter Maydell wrote:
> The virt_is_acpi_enabled() function is specific to the virt board, as
> is the check for its 'ras' property.  Use the new acpi_ghes_present()
> function to check whether we should report memory errors via
> acpi_ghes_record_errors().
> 
> This avoids a link error if QEMU was built without support for the
> virt board, and provides a mechanism that can be used by any future
> board models that want to add ACPI memory error reporting support
> (they only need to call acpi_ghes_add_fw_cfg()).
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   target/arm/kvm64.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-06-03 18:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 17:12 [PATCH 0/3] hw/acpi, arm: Provide and use acpi_ghes_present() Peter Maydell
2021-06-03 17:12 ` [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors() Peter Maydell
2021-06-03 18:52   ` Richard Henderson
2021-06-17 10:28     ` Paolo Bonzini
2021-06-17 12:25       ` Peter Maydell
2021-06-13 21:47   ` Dongjiu Geng
2021-06-03 17:12 ` [PATCH 2/3] hw/acpi: Provide function acpi_ghes_present() Peter Maydell
2021-06-03 18:55   ` Richard Henderson
2021-06-13 21:48   ` Dongjiu Geng
2021-06-03 17:12 ` [PATCH 3/3] target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors Peter Maydell
2021-06-03 18:56   ` Richard Henderson [this message]
2021-06-13 21:49   ` Dongjiu Geng
2021-06-15  9:19 ` [PATCH 0/3] hw/acpi, arm: Provide and use acpi_ghes_present() Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d77a000b-17dd-8c24-360b-ef40a8bb6b9b@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gengdongjiu1@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=swjoshi@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).