From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 10/10] accel/tcg: include cs_base in our hash calculations
Date: Fri, 5 May 2023 19:27:43 +0100 [thread overview]
Message-ID: <d77d29d9-c31b-7eb1-087e-d229c9e24ce0@linaro.org> (raw)
In-Reply-To: <20230505155336.137393-11-alex.bennee@linaro.org>
On 5/5/23 16:53, Alex Bennée wrote:
> + uint32_t flags, uint64_t flags2, uint32_t cf_mask)
> {
> - return qemu_xxhash6(phys_pc, pc, flags, cf_mask);
> + return qemu_xxhash8(phys_pc, pc, flags,
> + flags2 & 0xffff, flags2 >> 32, cf_mask);
Well not that mask, obviously. Either pass it whole, like pc, or just let the compiler
truncate for you without the mask.
r~
prev parent reply other threads:[~2023-05-05 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 15:53 [PATCH v3 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-05-05 15:53 ` [PATCH v3 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-05-05 15:53 ` [PATCH v3 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-05-05 15:53 ` [PATCH v3 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-05-05 15:53 ` [PATCH v3 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-05-06 7:34 ` Markus Armbruster
2023-05-05 15:53 ` [PATCH v3 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-05-06 7:20 ` Markus Armbruster
2023-05-05 15:53 ` [PATCH v3 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-05-10 7:46 ` Philippe Mathieu-Daudé
2023-05-23 12:11 ` Alex Bennée
2023-05-05 15:53 ` [PATCH v3 07/10] trace: remove control-vcpu.h Alex Bennée
2023-05-05 15:53 ` [PATCH v3 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-05-10 7:48 ` Philippe Mathieu-Daudé
2023-05-05 15:53 ` [PATCH v3 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-05-05 15:53 ` [PATCH v3 10/10] accel/tcg: include cs_base in our hash calculations Alex Bennée
2023-05-05 18:27 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77d29d9-c31b-7eb1-087e-d229c9e24ce0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).